rubocop automatic fixes

Author: isimluk

Gemfile

@@ -1,3 +1,5 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 gemspec

Rakefile

@@ -7,5 +7,5 @@ Bundler::GemHelper.install_tasks :name => 'openscap'
 task :test do
   $LOAD_PATH.unshift('lib')
   $LOAD_PATH.unshift('test')
-  Dir.glob('./test/**/*_test.rb') { |f| require f }
+  Dir.glob('./test/**/*_test.rb').each { |f| require f }
 end

lib/openscap/xccdf/item.rb

@@ -25,7 +25,7 @@ def self.build(t)
       end
 
       def initialize(t)
-        if self.class == OpenSCAP::Xccdf::Item
+        if instance_of?(OpenSCAP::Xccdf::Item)
           raise OpenSCAP::OpenSCAPError, "Cannot initialize #{self.class.name} abstract base class."
         end
 

lib/openscap/xccdf/session.rb

@@ -31,7 +31,7 @@ def load(opts = {})
       def profile=(p)
         @profile = p
         if OpenSCAP.xccdf_session_set_profile_id(@s, p) == false
-          raise OpenSCAPError, "No profile '" + p + "' found"
+          raise OpenSCAPError, "No profile '#{p}' found"
         end
       end
 

lib/openscap/xccdf/testresult.rb

@@ -8,8 +8,7 @@
 module OpenSCAP
   module Xccdf
     class TestResult
-      attr_reader :rr
-      attr_reader :raw
+      attr_reader :rr, :raw
 
       def initialize(t)
         case t

openscap.gemspec

@@ -6,7 +6,6 @@ require File.expand_path('lib/openscap/version', __dir__)
 GEMSPEC = Gem::Specification.new do |gem|
   gem.name = 'openscap'
   gem.version = OpenSCAP::VERSION
-  gem.date = Date.today.to_s
   gem.platform = Gem::Platform::RUBY
 
   gem.author = 'Simon Lukasik'

test/ds/arf_test.rb

@@ -15,7 +15,7 @@ def test_arf_new_nil
     rescue OpenSCAP::OpenSCAPError => e
       msg = e.to_s
     end
-    assert msg.start_with?("Cannot initialize OpenSCAP::DS::Arf with ''"), 'Message was: ' + msg
+    assert msg.start_with?("Cannot initialize OpenSCAP::DS::Arf with ''"), "Message was: #{msg}"
   end
 
   def test_arf_new_wrong_format
@@ -27,7 +27,7 @@ def test_arf_new_wrong_format
       msg = e.to_s
     end
     assert msg.include?('Could not create Result DataStream session: File is not Result DataStream.'),
-           'Message was: ' + msg
+           "Message was: #{msg}"
   end
 
   def test_create_arf_and_get_html
@@ -58,7 +58,7 @@ def test_new_memory
 
   def test_new_bz_memory
     bziped_file = new_arf_bz
-    raw_data = File.open(bziped_file, 'rb').read
+    raw_data = File.binread(bziped_file)
     assert !raw_data.empty?
     len = File.size(bziped_file)
     FileUtils.rm bziped_file
@@ -77,8 +77,8 @@ def test_new_bz_file
 
   def new_arf_bz
     create_arf
-    system('/usr/bin/bzip2 ' + REPORT)
-    REPORT + '.bz2'
+    system("/usr/bin/bzip2 #{REPORT}")
+    "#{REPORT}.bz2"
   end
 
   def new_arf

test/source_test.rb

@@ -13,7 +13,7 @@ def test_source_new_nil
     rescue OpenSCAP::OpenSCAPError => e
       msg = e.to_s
     end
-    assert msg.start_with?('No filename specified!'), 'Message was: ' + msg
+    assert msg.start_with?('No filename specified!'), "Message was: #{msg}"
   end
 
   def test_source_new_ok
@@ -59,11 +59,11 @@ def test_validate_invalid
       msg = e.to_s
     end
     assert msg.start_with?('Invalid XCCDF Checklist (1.2) content in ../data/invalid.xml.'),
-           'Message was: ' + msg
+           "Message was: #{msg}"
     assert msg.include?("../data/invalid.xml:3: Element '{http"),
-           'Message was: ' + msg
+           "Message was: #{msg}"
     assert msg.include?('This element is not expected. Expected is'),
-           'Message was: ' + msg
+           "Message was: #{msg}"
     s.destroy
   end
 

test/xccdf/arf_test.rb

@@ -38,7 +38,6 @@ def benchmark_from_arf_file
     _test_results = arf.test_result
     source_datastream = arf.report_request
     bench_source = source_datastream.select_checklist!
-    benchmark = OpenSCAP::Xccdf::Benchmark.new(bench_source)
-    benchmark
+    OpenSCAP::Xccdf::Benchmark.new(bench_source)
   end
 end

test/xccdf/session_ds_test.rb

@@ -111,6 +111,6 @@ def test_remediate
   def assert_exported(files)
     # libopenscap compiled with --enable-debug creates debug files
     FileUtils.rm_rf(Dir.glob('oscap_debug.log.*'))
-    assert files.sort == Dir.glob('*').sort
+    assert files.sort == Dir.glob('*')
   end
 end