Update reload_push_options tests: sync -> update-clients

Author: maurice2k

tests/reload_push_options/README.md

@@ -18,12 +18,12 @@ cd tests/reload_push_options
 
 | Test | Description |
 |------|-------------|
-| 1 | Basic reload without sync - existing clients unchanged |
-| 2 | Sync with new route added |
-| 3 | Sync with route removed |
-| 4 | Sync with all routes removed |
-| 5 | Sync with only new routes (complete replacement) |
-| 6 | Sync with mixed changes (add + remove) |
+| 1 | Basic reload without update-clients - existing clients unchanged |
+| 2 | Update clients with new route added |
+| 3 | Update clients with route removed |
+| 4 | Update clients with all routes removed |
+| 5 | Update clients with only new routes (complete replacement) |
+| 6 | Update clients with mixed changes (add + remove) |
 | 7 | New client receives updated config |
 | 8 | Stress test with 500 routes |
 
@@ -60,7 +60,7 @@ nc localhost 7505
 help
 status
 reload-push-options
-reload-push-options sync
+reload-push-options update-clients
 ```
 
 ## Files

tests/reload_push_options/run.sh

@@ -80,13 +80,13 @@ cleanup() {
     rm -rf results/*
 }
 
-# Run test: update config, reload (with or without sync), verify routes
-# Args: test_name, client, sync (0|1|skip), config_content, must_have_pattern, must_not_have_pattern
-# sync=skip: don't send mgmt command, just verify routes (for reconnect tests)
+# Run test: update config, reload (with or without update-clients), verify routes
+# Args: test_name, client, update_clients (0|1|skip), config_content, must_have_pattern, must_not_have_pattern
+# update_clients=skip: don't send mgmt command, just verify routes (for reconnect tests)
 run_test() {
     local test_name="$1"
     local client="$2"
-    local sync="$3"
+    local update_clients="$3"
     local config_content="$4"
     local must_have="$5"
     local must_not_have="$6"
@@ -99,9 +99,9 @@ run_test() {
 
     update_server_config "$config_content"
 
-    if [ "$sync" != "skip" ]; then
+    if [ "$update_clients" != "skip" ]; then
         local cmd="reload-push-options"
-        [ "$sync" = "1" ] && cmd="reload-push-options sync"
+        [ "$update_clients" = "1" ] && cmd="reload-push-options update-clients"
 
         local result=$(mgmt "$cmd")
         echo "Management response: $result"
@@ -111,7 +111,7 @@ run_test() {
         fi
         pass "$test_name: command succeeded"
 
-        if [ "$sync" = "1" ]; then
+        if [ "$update_clients" = "1" ]; then
             wait_for_client_ready "$client" "$log_lines"
         else
             sleep 2
@@ -167,8 +167,8 @@ docker compose build
 docker compose up -d --wait
 wait_for_clients
 
-# Test 1: No sync - routes must NOT change (still have initial routes, not the new 192.168.30.0)
-run_test "Test 1: No sync" client1 0 \
+# Test 1: No update-clients - routes must NOT change (still have initial routes, not the new 192.168.30.0)
+run_test "Test 1: No update-clients" client1 0 \
     'push "route 192.168.10.0 255.255.255.0"
 push "route 192.168.20.0 255.255.255.0"
 push "route 192.168.30.0 255.255.255.0"
@@ -251,7 +251,7 @@ routes_config+='push "dhcp-option DNS 8.8.8.8"'
 update_server_config "$routes_config"
 
 log_lines=$(get_client_log_lines client1)
-result=$(mgmt "reload-push-options sync")
+result=$(mgmt "reload-push-options update-clients")
 echo "Management response: $result"
 
 if ! echo "$result" | grep -q "SUCCESS"; then