extend makePipe and IShell definition

Author: erossignon

lib/interfaces.ts

@@ -278,7 +278,8 @@ export interface OCC {
    *
    * @param profile
    */
-  makePipe(spine: IWire, profile: IWire): ISolid;
+  makePipe(spine: IWire, profile: IWire): IShell;
+  makePipe(spine: IFace, profile: IWire): ISolid;
 
   makeRevol(vertex: IVertex, axis: IAxisLike, angleDegree?: number): IEdge;
   makeRevol(edge: IEdge, axis: IAxisLike, angleDegree?: number): IFace;

test/debug_tools.ts

@@ -1,4 +1,4 @@
-import { ISolid } from "..";
+import { IShell, ISolid } from "..";
 
 const doDebug = true;
 export function dumpSolid(b: ISolid) {
@@ -30,3 +30,31 @@ export function dumpSolid(b: ISolid) {
     );
   }
 }
+export function dumpShell(b: IShell) {
+  if (doDebug) {
+    console.log("num faces    ", b.numFaces);
+    console.log("num edges    ", b.getEdges().length);
+    console.log("num vertices ", b.getVertices().length);
+    console.log(
+      " faces    = ",
+      b
+        .getFaces()
+        .map((e) => b.getShapeName(e))
+        .join(", ")
+    );
+    console.log(
+      " edges    = ",
+      b
+        .getEdges()
+        .map((e) => b.getShapeName(e))
+        .join(", ")
+    );
+    console.log(
+      " vertices = ",
+      b
+        .getVertices()
+        .map((e) => b.getShapeName(e))
+        .join(", ")
+    );
+  }
+}

test/test_makePipe.ts

@@ -1,11 +1,38 @@
 import should from "should";
 import { Vertex, occ } from "..";
+import { dumpSolid, dumpShell } from "./debug_tools";
 describe("makePipe", () => {
-  it("should make a pipe from 2 circles", () => {
-    const wire1 = occ.makeCircle([0, 0, 0], [0, 0, 1], 10);
+  it("should make a pipe from a spine which is a  wire (circle) and a profile line ", () => {
+    const wire1 = occ.makeWire(occ.makeCircle([0, 0, 0], [0, 0, 1], 10));
 
-    const spine = occ.makeLine([0, 0, 0], [0, 0, 10]);
-
-    ///   const solid = occ.makePipe(spine, wire1);
+    const spine = occ.makeInterpolatedCurve(
+      [
+        [0, 0, 0],
+        [0, 6, 10],
+        [0, 0, 20]
+      ],
+      false,
+      0.01
+    );
+    const wire = occ.makeWire(spine);
+    const shell = occ.makePipe(wire, wire1);
+    dumpShell(shell);
   });
+
+  // it("should make a pipe from a spine which is a  Face and a profile line ", () => {
+
+  //   const wire1 = occ.makeWire(occ.makeCircle([0, 0, 0], [0, 0, 1], 10));
+  //   const face = occ.makeFace(wire1);
+
+  //   const spine = occ.makeWire(occ.makeInterpolatedCurve(
+  //     [
+  //       [0, 0, 0],
+  //       [0, 6, 10],
+  //       [0, 0, 20],
+
+  //     ], false, 0.01));
+
+  //   const solid = occ.makePipe(face, spine);
+  //   dumpSolid(solid);
+  // });
 });