PSR2/SwitchDeclaration: make implied semicolon via close tag auto-fixable

The `PSR2.ControlStructures.SwitchDeclaration` sniff includes a rule/error flagging when the scope opener is not a `:` colon.
This error was previously already made auto-fixable when the `scope_opener` is a semi-colon (via PR 1161).

This commit now also makes that error auto-fixable if the `scope_opener` is a PHP close tag.

Includes tests.
These tests also document how the sniff otherwise behaves when the code within a `switch` moves in and out of PHP a lot.

Author: jrfnl

src/Standards/PSR2/Sniffs/ControlStructures/SwitchDeclarationSniff.php

@@ -186,10 +186,15 @@ public function process(File $phpcsFile, int $stackPtr)
                 }
             } else {
                 $error = strtoupper($type) . ' statements must be defined using a colon';
-                if ($tokens[$opener]['code'] === T_SEMICOLON) {
+                if ($tokens[$opener]['code'] === T_SEMICOLON || $tokens[$opener]['code'] === T_CLOSE_TAG) {
                     $fix = $phpcsFile->addFixableError($error, $nextCase, 'WrongOpener' . $type);
                     if ($fix === true) {
-                        $phpcsFile->fixer->replaceToken($opener, ':');
+                        if ($tokens[$opener]['code'] === T_SEMICOLON) {
+                            $phpcsFile->fixer->replaceToken($opener, ':');
+                        } else {
+                            $prevNonEmpty = $phpcsFile->findPrevious(T_WHITESPACE, ($opener - 1), null, true);
+                            $phpcsFile->fixer->addContent($prevNonEmpty, ':');
+                        }
                     }
                 } else {
                     // Probably a case/default statement with colon + curly braces.

src/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc

@@ -622,3 +622,19 @@ switch ($value) {
     default ;
         echo 'Other';
 }
+
+// Verify that case/default statements with a PHP close tag as scope opener are handled correctly by the sniff.
+switch ($foo):
+    case "foo"?>
+        <div>Some html</div>
+        <?php break;
+    case "bar" ; ?>
+        <div>Some html</div>
+        <?php break;
+    default ?>
+        <div>Some html</div>
+        <?php break;
+    default ; ?>
+        <div>Some html</div>
+        <?php break;
+endswitch;

src/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc.fixed

@@ -617,3 +617,27 @@ switch ($value) {
     default:
         echo 'Other';
 }
+
+// Verify that case/default statements with a PHP close tag as scope opener are handled correctly by the sniff.
+switch ($foo):
+    case "foo":
+        ?>
+        <div>Some html</div>
+        <?php
+        break;
+    case "bar": 
+        ?>
+        <div>Some html</div>
+        <?php
+        break;
+    default: 
+        ?>
+        <div>Some html</div>
+        <?php
+        break;
+    default: 
+        ?>
+        <div>Some html</div>
+        <?php
+        break;
+endswitch;

src/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.php

@@ -69,6 +69,10 @@ public function getErrorList()
             617 => 1,
             620 => 1,
             622 => 1,
+            628 => 1,
+            631 => 1,
+            634 => 1,
+            637 => 1,
         ];
     }