Squiz/NonExecutableCode: bug fix - false positive with PHP close tag after case/default

The `Squiz.PHP.NonExecutableCode` sniff would flag PHP open/close tags and indentation whitespace in inline HTML as (non-)executable code, while these tokens should be disregarded for the purposes of this sniff.

Fixed now.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/NonExecutableCodeSniff.php

@@ -145,7 +145,11 @@ public function process(File $phpcsFile, int $stackPtr)
                 if ($next !== false) {
                     $lastLine = $tokens[$end]['line'];
                     for ($i = ($stackPtr + 1); $i < $next; $i++) {
-                        if (isset(Tokens::EMPTY_TOKENS[$tokens[$i]['code']]) === true) {
+                        if (isset(Tokens::EMPTY_TOKENS[$tokens[$i]['code']]) === true
+                            || $tokens[$i]['code'] === T_OPEN_TAG
+                            || $tokens[$i]['code'] === T_CLOSE_TAG
+                            || ($tokens[$i]['code'] === T_INLINE_HTML && trim($tokens[$i]['content']) === '')
+                        ) {
                             continue;
                         }
 

src/Standards/Squiz/Tests/PHP/NonExecutableCodeUnitTest.3.inc

@@ -62,3 +62,29 @@
         <?= 'unreachable - with semicolon'; ?>
     <?php endforeach; ?>
 <?php endif; ?>
+
+<!-- No problem here. -->
+<!-- Mind: the case/default statements all miss an explicit semicolon. This is perfectly valid PHP though. -->
+<?php switch(true): ?>
+    <?php case 'foo' ?>
+        <div>executable</div>
+        <?php break; ?>
+    <?php case 'bar' ?>
+        <?php return ?>
+    <?php default ?>
+        <div>executable</div>
+        <?php goto LABEL; ?>
+<?php endswitch ?>
+
+<!-- Should detect errors here. -->
+<?php switch(true): ?>
+    <?php case 'foo' ?>
+        <?php break; ?>
+        <div>non-executable</div>
+    <?php case 'bar' ?>
+        <?php return; ?>
+        <div>non-executable</div>
+    <?php default ?>
+        <?php goto LABEL ?>
+        <div>non-executable</div>
+<?php endswitch ?>

src/Standards/Squiz/Tests/PHP/NonExecutableCodeUnitTest.php

@@ -115,6 +115,9 @@ public function getWarningList($testFile = '')
                     45 => 1,
                     54 => 1,
                     62 => 1,
+                    83 => 1,
+                    86 => 1,
+                    89 => 1,
                 ];
             default:
                 return [];