Move the return to the correct location to save processing time (request #1058)

gsherwood · gsherwood · commit ea32814346ec · 2016-07-05T10:36:54.000+10:00
diff --git a/CodeSniffer/Standards/Squiz/Sniffs/Arrays/ArrayDeclarationSniff.php b/CodeSniffer/Standards/Squiz/Sniffs/Arrays/ArrayDeclarationSniff.php
@@ -120,11 +120,11 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
 
                     $phpcsFile->fixer->endChangeset();
                 }
-
-                // We can return here because there is nothing else to check. All code
-                // below can assume that the array is not empty.
-                return;
             }
+
+            // We can return here because there is nothing else to check. All code
+            // below can assume that the array is not empty.
+            return;
         }
 
         if ($tokens[$arrayStart]['line'] === $tokens[$arrayEnd]['line']) {

Original file line number	Diff line number	Diff line change
`@@ -120,11 +120,11 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)`
`120`	`120`
`121`	`121`	`$phpcsFile->fixer->endChangeset();`
`122`	`122`	`}`
`123`		`-`
`124`		`- // We can return here because there is nothing else to check. All code`
`125`		`- // below can assume that the array is not empty.`
`126`		`- return;`
`127`	`123`	`}`
	`124`	`+`
	`125`	`+ // We can return here because there is nothing else to check. All code`
	`126`	`+ // below can assume that the array is not empty.`
	`127`	`+ return;`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`if ($tokens[$arrayStart]['line'] === $tokens[$arrayEnd]['line']) {`