Squiz.Arrays.ArrayDeclaration.ValueNoNewline false positive with anonymous classes

[ostrolucky]

Describe the bug

It seems that if array is embedded in an anon class in an array, sniff wrongly detects range of arrays. Following gives

FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
  9 | ERROR | [x] The first value in a multi-value array must be on a new line (Squiz.Arrays.ArrayDeclaration.ValueNoNewline)
  9 | ERROR | [x] Each value in a multi-line array must be on a new line (Squiz.Arrays.ArrayDeclaration.ValueNoNewline)
------------------------------------------------------------------------------------------------------------------------------

and phpcbf fails to fix it.

Code sample

foo(
    ExperimentRegistry::class,
    new ArrayExperimentRegistry([
        new class implements Experiment {
            public function getDefaults(): object
            {
                return (object)['foo' => 'bar'];
            }
        },
    ]),
);

Expected behavior

No error

Versions (please complete the following information)

Operating System	Debian 12 (official PHP docker image)
PHP version	8.4
PHP_CodeSniffer version	3.13.2
Standard	Doctrine
Install type	Composer local

Additional context

Add any other context about the problem here.

Please confirm

• I have searched the issue list and am not opening a duplicate issue.
• I have read the Contribution Guidelines and this is not a support question.
• I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
• I have verified the issue still exists in the master branch of PHP_CodeSniffer.

[rodrigoprimo]

Thanks for your report, @ostrolucky. I was able to confirm this bug. The sniff fails to skip the tokens inside the anonymous class definition when finding all the elements of the external array. Here is a simplified code sample that causes the same problem:

$array = [
    new class {
        public $var = array('bar');
    },
];

@LastDragon-ru shared another code sample that causes the same issue as a comment in another issue:

class Bug {
    public static function bug(): mixed {
        return [
            'paginator' => [
                new class() {
                    public function toArray(): mixed {
                        return [];
                    }
                },
            ],
        ];
    }
}

I believe the solution will involve updating the if condition below to make the sniff skip over the contents of anonymous class definitions (as it already does for arrays, anonymous functions, and match):

PHP_CodeSniffer/src/Standards/Squiz/Sniffs/Arrays/ArrayDeclarationSniff.php

Lines 399 to 428 in 8e0074a

	if ($tokens[$nextToken]['code'] === T_ARRAY
	|| $tokens[$nextToken]['code'] === T_OPEN_SHORT_ARRAY
	|| $tokens[$nextToken]['code'] === T_CLOSURE
	|| $tokens[$nextToken]['code'] === T_FN
	|| $tokens[$nextToken]['code'] === T_MATCH
	) {
	// Let subsequent calls of this test handle nested arrays.
	if ($tokens[$lastToken]['code'] !== T_DOUBLE_ARROW) {
	$indices[] = ['value' => $nextToken];
	$lastToken = $nextToken;
	}
	if ($tokens[$nextToken]['code'] === T_ARRAY) {
	$nextToken = $tokens[$tokens[$nextToken]['parenthesis_opener']]['parenthesis_closer'];
	} else if ($tokens[$nextToken]['code'] === T_OPEN_SHORT_ARRAY) {
	$nextToken = $tokens[$nextToken]['bracket_closer'];
	} else {
	// T_CLOSURE.
	$nextToken = $tokens[$nextToken]['scope_closer'];
	}
	$nextToken = $phpcsFile->findNext(T_WHITESPACE, ($nextToken + 1), null, true);
	if ($tokens[$nextToken]['code'] !== T_COMMA) {
	$nextToken--;
	} else {
	$lastToken = $nextToken;
	}
	continue;
	}//end if

That being said, I believe what @jrfnl said in #559 (comment) also applies to this issue (@jrfnl, please correct me if that is not the case):

The Squiz.Arrays.ArrayDeclaration sniff is known to be problematic and has been for years.

The problem is largely that as soon as something is excluded from that sniff, the sniff is broken. This is a design flaw in the sniff.

I've been building up a (highly configurable) NormalizedArrays standard in PHPCSExtra to replace it, but that's not complete yet. Would be lovely if I could find some time to finish that at some point.

With that in mind, I will not be working on this issue.
If someone would submit a PR with a small/simple fix for this issue, I will accept it, but other than that, this sniff is out of bounds for large fixes/rewrites as it is just not worth the time.