Skip to content

Commit 77133d5

Browse files
committed
Github Action : Roave BC Check
1 parent e76b701 commit 77133d5

File tree

4 files changed

+39
-4
lines changed

4 files changed

+39
-4
lines changed

.github/workflows/php.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,3 +163,13 @@ jobs:
163163
wget https://github.com/php-coveralls/php-coveralls/releases/download/v2.4.3/php-coveralls.phar
164164
chmod +x php-coveralls.phar
165165
php php-coveralls.phar --coverage_clover=build/clover.xml --json_path=build/coveralls-upload.json -vvv
166+
167+
roave-backwards-compatibility-check:
168+
name: Roave Backwards Compatibility Check
169+
runs-on: ubuntu-latest
170+
steps:
171+
- uses: actions/checkout@v4
172+
with:
173+
fetch-depth: 0
174+
- name: "Check for BC breaks"
175+
run: docker run -u $(id -u) -v $(pwd):/app nyholm/roave-bc-check-ga

docs/changes/1.x/1.2.0.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
- ODText / RTF / Word2007 Writer : Add field FILENAME by [@milkyway-git](https://github.com/milkyway-git) in [#2510](https://github.com/PHPOffice/PHPWord/pull/2510)
3434
- ODText Reader : Improve Section Reader by [@oleibman](https://github.com/oleibman) in [#2507](https://github.com/PHPOffice/PHPWord/pull/2507)
3535

36-
### Bug fixes
36+
## Bug fixes
3737

3838
- Fixed wrong mimetype for docx files by [@gamerlv](https://github.com/gamerlv) in GH-2416
3939
- Word2007 Reader : Read hyperlingks in headings by [@hannesdorn](https://github.com/hannesdorn) in GH-2433
@@ -44,7 +44,7 @@
4444
- Word2007 Reader : Fixed reading of Office365 DocX file by [@filippotoso](https://github.com/filippotoso) & [@lfglopes](https://github.com/lfglopes) in [#2506](https://github.com/PHPOffice/PHPWord/pull/2506)
4545
- Word2007 Reader : Check for null on $fontDefaultStyle by [@spatialfree](https://github.com/spatialfree) in [#2513](https://github.com/PHPOffice/PHPWord/pull/2513)
4646

47-
### Miscellaneous
47+
## Miscellaneous
4848

4949
- Added PHPStan by [@PowerKiKi](https://github.com/PowerKiKi) in GH-2405
5050
- Bump symfony/process from 4.4.44 to 5.4.26 by [@dependabot](https://github.com/dependabot) in GH-2431
@@ -61,7 +61,7 @@
6161
- Bump tecnickcom/tcpdf from 6.6.2 to 6.6.5 by [@dependabot](https://github.com/dependabot) in [#2482](https://github.com/PHPOffice/PHPWord/pull/2482)
6262
- Bump phpmd/phpmd from 2.13.0 to 2.14.1 by [@dependabot](https://github.com/dependabot) in [#2483](https://github.com/PHPOffice/PHPWord/pull/2483)
6363
- Bump phpstan/phpstan-phpunit from 1.3.14 to 1.3.15 by [@dependabot](https://github.com/dependabot) in [#2494](https://github.com/PHPOffice/PHPWord/pull/2494)
64+
- Github Action : Roave BC Check by [@Progi1984](https://github/Progi1984) in [#](https://github.com/PHPOffice/PHPWord/pull/)
6465

65-
66-
### BC Breaks
66+
## BC Breaks
6767
- Removed dependency `laminas/laminas-escaper`

docs/changes/2.x/2.0.0.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# [2.0.0](https://github.com/PHPOffice/PHPWord/tree/2.0.0) (WIP)
2+
3+
### BC Breaks
4+
- Removed dependency `laminas/laminas-escaper`
5+
- Changed: The return type of PhpOffice\PhpWord\Metadata\Settings#getThemeFontLang() changed from no type to PhpOffice\PhpWord\Style\Language|null
6+
- Changed: The return type of PhpOffice\PhpWord\Metadata\Settings#setThemeFontLang() changed from void to the non-covariant self
7+
- Changed: The return type of PhpOffice\PhpWord\Metadata\Settings#setThemeFontLang() changed from void to self
8+
- Changed: The parameter $themeFontLang of PhpOffice\PhpWord\Metadata\Settings#setThemeFontLang() changed from no type to a non-contravariant PhpOffice\PhpWord\Style\Language
9+
- Changed: The parameter $themeFontLang of PhpOffice\PhpWord\Metadata\Settings#setThemeFontLang() changed from no type to PhpOffice\PhpWord\Style\Language
10+
- Changed: The number of required arguments for PhpOffice\PhpWord\Style\Indentation#setLeft() increased from 0 to 1
11+
- Changed: The number of required arguments for PhpOffice\PhpWord\Style\Indentation#setRight() increased from 0 to 1
12+
- Changed: The number of required arguments for PhpOffice\PhpWord\Style\Indentation#setFirstLine() increased from 0 to 1
13+
- Changed: The number of required arguments for PhpOffice\PhpWord\Shared\Html::mapAlign() increased from 1 to 2

roave-bc-check.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
parameters:
2+
ignoreErrors:
3+
# 1.2.0
4+
- '#\[BC\] CHANGED\: The return type of PhpOffice\\PhpWord\\Metadata\\Settings\#getThemeFontLang\(\) changed from no type to PhpOffice\\PhpWord\\Style\\Language|null#'
5+
- '#\[BC\] CHANGED\: The return type of PhpOffice\\PhpWord\\Metadata\\Settings\#setThemeFontLang\(\) changed from void to self#'
6+
- '#\[BC\] CHANGED\: The return type of PhpOffice\\PhpWord\\Metadata\\Settings\#setThemeFontLang\(\) changed from void to the non-covariant self#'
7+
- '#\[BC\] CHANGED\: The parameter \$themeFontLang of PhpOffice\\PhpWord\\Metadata\\Settings\#setThemeFontLang\(\) changed from no type to a non-contravariant PhpOffice\\PhpWord\\Style\\Language#'
8+
- '#\[BC\] CHANGED\: The parameter \$themeFontLang of PhpOffice\\PhpWord\\Metadata\\Settings\#setThemeFontLang\(\) changed from no type to PhpOffice\\PhpWord\\Style\\Language#'
9+
- '#\[BC\] CHANGED\: The number of required arguments for PhpOffice\\PhpWord\\Style\\Indentation\#setLeft\(\) increased from 0 to 1#'
10+
- '#\[BC\] CHANGED\: The number of required arguments for PhpOffice\\PhpWord\\Style\\Indentation\#setRight\(\) increased from 0 to 1#'
11+
- '#\[BC\] CHANGED\: The number of required arguments for PhpOffice\\PhpWord\\Style\\Indentation\#setFirstLine\(\) increased from 0 to 1#'
12+
- '#\[BC\] CHANGED\: The number of required arguments for PhpOffice\\PhpWord\\Shared\\Html\:\:mapAlign\(\) increased from 1 to 2#'

0 commit comments

Comments
 (0)