Skip to content

Commit 4634ad6

Browse files
authored
Fix error handling and use segment_index starting from zero (#589)
* Update uploadMedia to use new dedicated endpoints for chunked media upload in V2 * Minor fixes * Fix error handling in V2 * Use segment_index starting from zero * Make sure segment_index starts from zero
1 parent b1aa131 commit 4634ad6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/client-mixins/request-handler.helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class RequestHandlerHelper<T> {
9898
if (data?.errors?.length) {
9999
const errors = data.errors as (ErrorV1 | ErrorV2)[];
100100

101-
if ('code' in errors[0]) {
101+
if (typeof errors[0] === 'object' && 'code' in errors[0]) {
102102
errorString += ' - ' + this.formatV1Errors(errors as ErrorV1[]);
103103
}
104104
else {

src/v2/client.v2.write.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ export default class TwitterApiv2ReadWrite extends TwitterApiv2ReadOnly {
168168
const chunkedBuffer = Buffer.from(mediaChunk);
169169

170170
const appendArguments: MediaV2UploadAppendParams = {
171-
segment_index: i + 1,
171+
segment_index: i,
172172
media: chunkedBuffer,
173173
};
174174

0 commit comments

Comments
 (0)