[Bug] Add better documentation regarding removed auto-elevation within the exe.

[eprowe]

Prerequisites

• Ensure you write a short, descriptive title after [Bug] above.
• Make sure to search for any existing issues before filing a new one.
• Verify you are able to reproduce the issue with the latest released version

PSAppDeployToolkit version

4.1.0

Describe the bug

Launching Invoke-AppDeployToolkit.exe from a 4.1.0 deployment fails to display a UAC prompt and silently fails. Using /debug yields the following:

Open-ADTSession : This deployment requires administrative permissions and the current user is not an Administrator, or
PowerShell is not elevated. Please re-run the deployment script as an Administrator and try again.
At C:\{Redacted}\Invoke-AppDeployToolkit.ps1:332 char:19
+     $adtSession = Open-ADTSession @adtSession @iadtParams -PassThru
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OpenError: (60008:Int32) [Open-ADTSession], UnauthorizedAccessException
    + FullyQualifiedErrorId : System.UnauthorizedAccessException,Open-ADTSession

Steps to reproduce

1. Create a new 4.1.0 deployment.
2. Execute Invoke-AppDeployToolkit.exe without elevation.
3. Nothing happens.

Environment data

OsName               : Microsoft Windows 11 Enterprise
OSDisplayVersion     : 24H2
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsProductName   : Windows 10 Enterprise
WindowsBuildLabEx    : 26100.1.amd64fre.ge_release.240331-1435
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
KeyboardLayout       : en-US
TimeZone             : (UTC-08:00) Pacific Time (US & Canada)
HyperVisorPresent    : True
CsPartOfDomain       : True
CsPCSystemType       : Desktop

dotnet : The term 'dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:270
+ ... 'HyperVisorPresent','CsPartOfDomain','CsPCSystemType'); dotnet --info
+                                                             ~~~~~~
    + CategoryInfo          : ObjectNotFound: (dotnet:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

[mjr4077au]

This is deliberate because it's not appropriate for users to just have random UAC prompts appear on their screens. We also foresee it to be an issue with the upcoming Administrator Protection changes in Windows 11. It's usage was also mostly there to support you as the admin testing a deployment by double clicking the executable. If it's just the latter, you can simply right click on the executable and select Run as Administrator.

[eprowe]

My apologies this wasn't support to be closed.

[eprowe]

Maybe I'm misunderstanding the operations. If I were distributing a PSADT deployment to an individual with instructions to either directly launch the EXE or a script to do the same, it is desired to simply have nothing happen at all? If I'm allowing users to elevate their permissions they'd have no way of knowing to do so without being provided additional instruction. If this is the new model that's fine I'll adjust; however, it's a jarring change from 4.0.6 with no mention in any docs.

Once again sorry for mucking up the closing/opening.

[mjr4077au]

It's hinted at here by way of the overall RequireAdmin changes, but I agree that it's not explicit enough. We'll get the documentation addressed so it's explicitly stated.

[eprowe]

I reviewed the link you shared and previously created deployments. All my deployments have RequireAdmin set to true. For completeness what is currently happening is:

RequireAdmin = $true

Launching Invoke-AppDeployToolkit.exe does nothing. No UI. No log file.

Combined with /debug yields the submitted details.

RequireAdmin = $false

Launching Invoke-AppDeploytoolkit.exe displays the UI. If Invoke-AppDeployToolkit.ps1 contains an instruction which requires elevation, the closing UI is briefly displayed with no indication of an error. No log file.

Combined with /debug at least provides feedback that the process failed with:

Message : Cannot validate argument on parameter 'Path'. The requested operation requires elevation.

With 4.0.6:

RequireAdmin = $true

Launching Invoke-AppDeployToolkit.exe user receives a UAC prompt before continuing.

RequireAdmin = $false

Launching Invoke-AppDeployToolkit.exe user receives no UAC prompt; however, an error record is displayed when an instruction requiring elevation is invoked. No log file. The error record mentions:

Message : The requested operation requires elevation.

Upon pressing ok, a final pop-up is displayed indicating 'An error occurred while running...'

[mjr4077au]

I get all of that. By 'hinting', I meant that it was hinted that there was changes in this general area. The exe is not wired to go and read the contents of your script to determine whether RequireAdmin is true or not though, and as said it was by design for 4.1.0. I'll ensure it gets called out properly though to avoid any confusion as I agree that it's insufficiently stipulated.