Wrong ProvidePlugin of URL

[weareoutman]

Describe the bug

The PR #1089 introduced ProvidePlugin for 'URL' from 'url', but URL is not included in node url module.

This causes a browser error of Q is not a constructor if any client code includes new URL(...)

Expected behavior

No error with client code new URL(...)

Current behavior

Error in browser

Possible solution

Remove the fallback settings of 'URL'.

Steps to reproduce

Edit: this is not reproducible any more, since they downgraded this plugin to an older version to workaround the issue.

1. Open https://docs.port.io/
2. Click the search bar at top-right
3. An error reported in browser console.

Screenshots

Context

Your Environment

• Version used: 4.3.5
• Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3):
• Operating System and version (desktop or mobile):
• Link to your project: https://github.com/port-labs/port-docs

Related issue: easyops-cn/docusaurus-search-local#500

[weareoutman]

Not a webpack expert, but seems we can remove the URL entry from ProvidePlugin, while keep the url entry in resolve.fallback.

[sserrata]

Hi @weareoutman, thanks for reporting the issue. I was wondering if you or your team could help test canary release 0.0.0-984 to see if the issue is resolved?

[sserrata]

Disregard...seems there are still some webpack issues resolving modules...