fix: stop deployments for full cleanup PS-10081

Author: bbatha

paperspace/cli/deployments.py

@@ -124,15 +124,15 @@ def start_deployment(id_, api_key=None):
     command.execute(id_)
 
 
-@deployments.command("delete", help="Delete deployment")
+@deployments.command("stop", help="Stop deployment")
 @click.option(
     "--id",
     "id_",
     required=True,
     help="Deployment ID",
 )
 @api_key_option
-def delete_deployment(id_, api_key=None):
+def stop_deployment(id_, api_key=None):
     deployments_api = client.API(config.CONFIG_HOST, api_key=api_key)
-    command = deployments_commands.DeleteDeploymentCommand(api=deployments_api)
-    command.execute(id_)
+    command = deployments_commands.StopDeploymentCommand(api=deployments_api)
+    command.execute(id_)

paperspace/commands/deployments.py

@@ -74,12 +74,11 @@ def execute(self, deployment_id):
                           "Deployment started",
                           "Unknown error occurred.")
 
-
-class DeleteDeploymentCommand(_DeploymentCommandBase):
+class StopDeploymentCommand(_DeploymentCommandBase):
     def execute(self, deployment_id):
         json_ = {"id": deployment_id,
-                 "upd": {"isDeleted": True}}
+                 "isRunning": False}
         response = self.api.post("/deployments/updateDeployment/", json=json_)
         self._log_message(response,
-                          "Deployment deleted.",
+                          "Deployment stopped",
                           "Unknown error occurred.")

tests/functional/test_deployments.py

@@ -228,15 +228,15 @@ def test_should_send_proper_data_and_print_message_when_deployments_start_was_us
         assert result.exit_code == 0
 
 
-class TestDeleteDeployment(object):
+class TestStopDeployment(object):
     URL = "https://api.paperspace.io/deployments/updateDeployment/"
-    COMMAND = ["deployments", "delete",
+    COMMAND = ["deployments", "stop",
                "--id", "some_id"]
-    REQUEST_JSON = {"upd": {"isDeleted": True}, "id": u"some_id"}
-    EXPECTED_STDOUT = "Deployment deleted.\n"
+    REQUEST_JSON = {"isRunning": False, "id": u"some_id"}
+    EXPECTED_STDOUT = "Deployment stopped\n"
 
     COMMAND_WITH_API_KEY = [
-        "deployments", "delete",
+        "deployments", "stop",
         "--id", "some_id",
         "--apiKey", "some_key",
     ]
@@ -247,7 +247,7 @@ class TestDeleteDeployment(object):
     EXPECTED_STDOUT_WITH_WRONG_ID = "Unable to access deployment\n"
 
     @mock.patch("paperspace.cli.deployments.deployments_commands.client.requests.post")
-    def test_should_send_proper_data_and_print_message_when_deployments_delete_was_used(self, post_patched):
+    def test_should_send_proper_data_and_print_message_when_deployments_stop_was_used(self, post_patched):
         post_patched.return_value = MockResponse(status_code=204)
 
         runner = CliRunner()
@@ -277,7 +277,7 @@ def test_should_send_proper_data_with_custom_api_key_when_api_key_parameter_was_
         assert result.exit_code == 0
 
     @mock.patch("paperspace.cli.deployments.deployments_commands.client.requests.post")
-    def test_should_send_proper_data_and_print_message_when_deployments_delete_used_with_wrong_id(self, post_patched):
+    def test_should_send_proper_data_and_print_message_when_deployments_stop_used_with_wrong_id(self, post_patched):
         post_patched.return_value = MockResponse(self.RESPONSE_JSON_400, 400, "fake content")
 
         runner = CliRunner()