avoiding for loop

Author: wbaccinelli

niceday-broker/index.js

@@ -14,11 +14,11 @@ require('dotenv').config();
 const { THERAPIST_PASSWORD, THERAPIST_EMAIL_ADDRESS, ENVIRONMENT } = process.env;
 let { RASA_AGENT_URL } = process.env;
 RASA_AGENT_URL = (RASA_AGENT_URL === undefined) ? 'http://rasa_server:5005/webhooks/rest/webhook' : RASA_AGENT_URL;
-// proportional factor between the number of words in a message and the time to wait before the 
-// newt message is delivered 
-WORDS_PER_SECOND = 5
+// proportional factor between the number of words in a message and the time to wait before the
+// newt message is delivered
+const WORDS_PER_SECOND = 5;
 // maximum delay between a message and the next one
-MAX_DELAY = 10
+const MAX_DELAY = 10;
 
 const chatSdk = new Chat();
 let selectedServer;
@@ -80,28 +80,25 @@ function sleep(ms) {
 async function onRasaResponse() {
   if (this.readyState === 4 && this.status === 200) {
     const responseJson = JSON.parse(this.responseText);
-    for (message of responseJson){
-          const attachment = {
+
+    const processMessage = async (message) => {
+      const attachment = {
         replyOfId: null,
-        attachmentIds: [],
+        attachmentIds: message.metadata || [],
       };
-      if ('metadata' in message) {
-        attachment.attachmentIds = message.metadata;
-      }
-      
-      sendMessage(message.text, parseInt(message.recipient_id, 10), attachment)
 
-      if (ENVIRONMENT === 'prod') {
-        const delay = (message.text.split(" ").length)/WORDS_PER_SECOND;
-        
-        if (delay > MAX_DELAY) {
-          delay = MAX_DELAY;
-        }
+      sendMessage(message.text, parseInt(message.recipient_id, 10), attachment);
 
-        await sleep(delay*1000);
+      if (ENVIRONMENT === 'prod') {
+        const delay = Math.min(MAX_DELAY, message.text.split(' ').length / WORDS_PER_SECOND);
+        await sleep(delay * 1000);
       }
-    }
+    };
 
+    await responseJson.reduce(async (prevPromise, message) => {
+      await prevPromise;
+      await processMessage(message);
+    }, Promise.resolve());
   } else if (this.readyState === 4) {
     console.log('Something went wrong, status:', this.status, this.responseText);
   }