Skip to content

Improving SDMPolygon compliance w/ GeoInterface #455

@gottacatchenall

Description

@gottacatchenall

A few things to do (eventually) for SDMPolygons from #451

Some points you may want to note:

  • The conversion you do in _polygonize is better accomplished by implementing the correct GeoInterface.convert methods. You can forward directly to GeoInterface.convert(ArchGDAL, geom) - that is substantially more efficient than using GI.coordinates, which is really a last-resort kind of thing.
  • With a full GeoInterface implementation you can simply use GeoInterfaceMakie.@enable YourGeometrySupertype to get full plotting functionality with any Makie point-based plot, and for Plots the call is GeoInterfaceRecipes.@enable .... The way the Makie integration is currently implemented won't work with most Makie features and will likely break often!
  • For best IO use, you may want to implement GeoInterface for your feature and feature collection types. You may also want to forward ismeasured, is3d, and isempty from GeoInterface to the wrapped GDAL geometry.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ❇️ SimpleSDMPolygonsChanges primarily affecting or taking place in SimpleSDMPolygons👾 externalIssues involving code or services external to this repo

    Type

    Projects

    Status

    Needs assessment

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions