Genus data for forms is missing

[omidantilong]

Hello, first off, thanks for the maintenance of this amazing project. It's such a useful learning tool.

I've been exploring the new GraphQL API over the last few days for a little project I'm working on.

I've noticed that genus is only returned at the species level. This is fine for most cases, but there are some Pokemon whose genus changes depending on their form. I expectedpokemonforms to return a form-specific genus.

Some examples of Pokémon where this happens:

• Rapidash Fire Horse -> Unique Horn
• Typhlosion Volcano -> Ghost Flame
• Slowking Royal -> Hexpert

I've linked to Bulbapedia there, but pokemondb.net has the correct form/genus values as well.

Am I missing something? I pulled the repo and did a global search for the correct values but can't see them in any of the CSV files.

Happy to help fix this if I can! Thanks ☺️

[omidantilong]

I've done some more digging and it looks like pokemoncolor has a similar issue — for example Vivillon has multiple colours depending on its form (see List of Pokémon by Color on Bulbapedia), but as with genus, pokemoncolor only exists on the species type.

[omidantilong]

@Naramsim i have collected all the data for this, but I'm really struggling to get the local dev environment set up. I can provide a json dump of all the values mapped to an id and formid if you are open to adding the data? Or I can add them straight to the CSVs and make a PR.

If anyone has a guide for getting the v2 graphql API running locally, that would be great. I can get hasura running using the docker method but it looks like its only the v1 API (or it's missing a lot of stuff...) 🤔

Thanks!

[Naramsim]

Hi, the setup should be straightforward.

make docker-setup
make hasura-apply

Just with these two commands you should get the gql up.

[omidantilong]

Hey, thanks for the reply. For a start I think I misread v1beta2 as v2, which doesn't help 😄 But I've tried again this morning and it seems to be going smoother than last night.

The server is up on port 8000. But when I tried to run make hasura-apply I got the following:

FATA[0000] {
  "error": "invalid \"x-hasura-admin-secret\"/\"x-hasura-access-key\"",
  "path": "$",
  "code": "access-denied"
} 
make: *** [hasura-apply] Error 1

I ended up running hasura md apply --project graphql/v1beta2 directly and passing in the admin-secret. I'll spend some time after work today getting my head round the CSVs.

Thanks for the pointers!