From 3cb9b6376758951419e7aa5dcf5a51177b040003 Mon Sep 17 00:00:00 2001 From: Justin Fagnani Date: Tue, 15 Sep 2015 03:23:34 -0700 Subject: [PATCH 1/2] Show register time --- src/elements/stats-table/stats-table.html | 2 ++ src/polymer-panel.html | 13 +++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/elements/stats-table/stats-table.html b/src/elements/stats-table/stats-table.html index 39527af..d1ff2b7 100644 --- a/src/elements/stats-table/stats-table.html +++ b/src/elements/stats-table/stats-table.html @@ -18,6 +18,7 @@
Tag Name
Count
Total Time
+
Register
Created
Attached
Detached
@@ -64,6 +65,7 @@
{{item.tagName}}
{{item.count}}
+ diff --git a/src/polymer-panel.html b/src/polymer-panel.html index c97d537..5aebc9e 100644 --- a/src/polymer-panel.html +++ b/src/polymer-panel.html @@ -96,6 +96,7 @@

Custom Element Profile

tagName: 'All Custom Elements', count: 0, totalTime: 0, + register: 0, created: 0, attached: 0, detached: 0, @@ -110,6 +111,7 @@

Custom Element Profile

tagName: tag, count: tagData.count, totalTime: 0, + register: (tagData.register) ? tagData.register.totalTime : 0, created: (tagData.created) ? tagData.created.totalTime : 0, attached: (tagData.attached) ? tagData.attached.totalTime : 0, detached: (tagData.detached) ? tagData.detached.totalTime : 0, @@ -118,16 +120,23 @@

Custom Element Profile

data: (tagData.data) ? tagData.data.totalTime : 0, }; tagStats.totalTime = + tagStats.register + tagStats.created + tagStats.attached + tagStats.detached + tagStats.data + tagStats.attributeChanged; displayData.push(tagStats); - this.maxCallbackTime = Math.max(this.maxCallbackTime, tagStats.created, - tagStats.attached, tagStats.detached, tagStats.attributeChanged); + this.maxCallbackTime = Math.max( + this.maxCallbackTime, + tagStats.register, + tagStats.created, + tagStats.attached, + tagStats.detached, + tagStats.attributeChanged); allTagsStats.count += tagStats.count; allTagsStats.totalTime += tagStats.totalTime; + allTagsStats.register += tagStats.register; allTagsStats.created += tagStats.created; allTagsStats.attached += tagStats.attached; allTagsStats.detached += tagStats.detached; From 2f5c897a79c4735676ea624c24b6fcc777ccbbca Mon Sep 17 00:00:00 2001 From: Justin Fagnani Date: Wed, 16 Sep 2015 16:25:15 -0700 Subject: [PATCH 2/2] Hide register time column behind a flag --- src/elements/stats-table/stats-table.html | 4 +++- src/polymer-panel.html | 17 ++++++++++++++--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/src/elements/stats-table/stats-table.html b/src/elements/stats-table/stats-table.html index d1ff2b7..56996af 100644 --- a/src/elements/stats-table/stats-table.html +++ b/src/elements/stats-table/stats-table.html @@ -65,7 +65,9 @@
{{item.tagName}}
{{item.count}}
- + diff --git a/src/polymer-panel.html b/src/polymer-panel.html index 5aebc9e..22cb246 100644 --- a/src/polymer-panel.html +++ b/src/polymer-panel.html @@ -63,7 +63,12 @@

Custom Element Profile

@@ -82,6 +87,8 @@

Custom Element Profile

allTagsStats: { type: Object, }, + + showRegisterColumn: Boolean, }, attached() { @@ -129,11 +136,15 @@

Custom Element Profile

displayData.push(tagStats); this.maxCallbackTime = Math.max( this.maxCallbackTime, - tagStats.register, tagStats.created, tagStats.attached, tagStats.detached, tagStats.attributeChanged); + if (showRegisterColumn) { + this.maxCallbackTime = Math.max( + this.maxCallbackTime, + tagStats.register); + } allTagsStats.count += tagStats.count; allTagsStats.totalTime += tagStats.totalTime; allTagsStats.register += tagStats.register; @@ -176,6 +187,6 @@

Custom Element Profile

})(); - +