fix: Stop generating incorrectly-named Rev Analytics views #39902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Not sure if this comment makes sense* but I still see some |
|
@jabahamondes It makes sense! Let me get rid of those too |
|
@jabahamondes ready for another review, ty! |
arthurdedeus
approved these changes
Oct 20, 2025
lricoy
approved these changes
Oct 20, 2025
I introduced these `no_something` for assertion purposes but they ended up in the generated view names, let's fix that
We don't need to do that step twice, just reuse the prefix
These will soon all go away anyway because we'll not be creating virtual revenue analytics functions anymore
rafaeelaudibert
force-pushed
the
fix-revenue-analytics-views-with-weird-names
branch
from
0f18096 to
08d36d5
Compare
rafaeelaudibert
deleted the
fix-revenue-analytics-views-with-weird-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced these
no_somethingfor assertion purposes, but they ended up in the generated view names, let's fix that