Do not dispose objects manually

alan-null · alan-null · commit 33cb9100e8cd · 2022-10-31T07:03:22.000+01:00
stream disposal causing input variable to be dispoed thus it cannot be chained - processed by other cmdlets
diff --git a/Photo.Shell/Photo.Shell.psd1 b/Photo.Shell/Photo.Shell.psd1
@@ -1,7 +1,7 @@
 
 @{
     RootModule        = 'Photo.Shell.psm1'
-    ModuleVersion     = '1.0.0'
+    ModuleVersion     = '1.0.1'
     GUID              = '7c120cb8-77c1-47aa-a17d-51ce26a679ae'
     Author            = 'Alan Plocieniak'
     CompanyName       = 'Alan Plocieniak'
diff --git a/Photo.Shell/Public/Compress-Image.ps1 b/Photo.Shell/Public/Compress-Image.ps1
@@ -45,7 +45,6 @@ function Compress-Image {
         }
         $img = [System.Drawing.Image]::FromStream($stream)
         $img.Save($result, $codec, $parameters)
-        $stream.Dispose()
         $result
     }
 
diff --git a/Photo.Shell/Public/Resize-Image.ps1 b/Photo.Shell/Public/Resize-Image.ps1
@@ -50,7 +50,6 @@ function Resize-Image {
 
         $graphics = [System.Drawing.Graphics]::FromImage($destImage)
         $graphics.DrawImage($img, 0, 0, $newWidth, $newHeight)
-        $graphics.Dispose()
 
         $stream2 = [System.IO.MemoryStream]::new()
         $destImage.Save($stream2, [System.Drawing.Imaging.ImageFormat]::Png)

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,6 @@ function Compress-Image {`
`45`	`45`	`}`
`46`	`46`	`$img = [System.Drawing.Image]::FromStream($stream)`
`47`	`47`	`$img.Save($result, $codec, $parameters)`
`48`		`- $stream.Dispose()`
`49`	`48`	`$result`
`50`	`49`	`}`
`51`	`50`