Merge branch 'FeatDeathMatch' of https://github.com/PrettyNeet/AccurateHerbChecker into FeatDeathMatch

Author: PrettyNeet

bot/utils/helpers.py

@@ -18,7 +18,10 @@ def generate_estimated_yield(farming_level, low_cts, high_cts, harvest_lives, it
     high_cts_final = math.floor(high_cts_final * (1 + attas_bonus))
 
     chance_to_save = skill_interp(low_cts_final, high_cts_final, farming_level)
-    return harvest_lives / (1 - chance_to_save)
+    if chance_to_save == 1:
+        return "Error: No yield calculated"
+    else:
+        return harvest_lives / (1 - chance_to_save)
 
 
 # Format the profit results into a markdown table

tests/test_utils.py

@@ -1 +1,41 @@
 # TODO create some unit tests
+import unittest
+from bot.utils.helpers import skill_interp, generate_estimated_yield
+
+class TestHelpers(unittest.TestCase):
+    def test_skill_interp(self):
+        # Test 1: Level 10-50
+        level = 20
+        low_cts = 1000
+        high_cts = 2000
+        self.assertAlmostEqual(skill_interp(low_cts, high_cts, level), 1, places=7)
+
+        # Test 2: Level 51-99
+        level = 70
+        low_cts = 1500
+        high_cts = 2500
+        self.assertAlmostEqual(skill_interp(low_cts, high_cts, level), 1, places=7)
+
+    def test_generate_estimated_yield(self):
+        # Test 1: Low CTs, High Yield
+        farming_level = 60
+        low_cts = 1000
+        high_cts = 2000
+        harvest_lives = 10
+        item_bonus = 0.05
+        diary_bonus = 5
+        attas_bonus = 0.1
+        self.assertAlmostEqual(generate_estimated_yield(farming_level, low_cts, high_cts, harvest_lives, item_bonus, diary_bonus, attas_bonus), "Error: No yield calculated")
+
+        # Test 2: High CTs, Low Yield
+        farming_level = 60
+        low_cts = 2000
+        high_cts = 3000
+        harvest_lives = 5
+        item_bonus = 0.05
+        diary_bonus = 5
+        attas_bonus = 0.1
+        self.assertAlmostEqual(generate_estimated_yield(farming_level, low_cts, high_cts, harvest_lives, item_bonus, diary_bonus, attas_bonus), "Error: No yield calculated")
+
+if __name__ == "__main__":
+    unittest.main()