Skip to content

Commit 1834a6b

Browse files
committed
Fix dismiss actions
1 parent 34d5cee commit 1834a6b

File tree

3 files changed

+64
-40
lines changed

3 files changed

+64
-40
lines changed

src/components/collapse/useCollapse.js

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,28 @@ export default function useCollapse(
2121
identifier,
2222
visible,
2323
setVisible,
24-
trigger: ({ dismiss }) => ({
25-
props: {
26-
onPress: () => {
27-
if (dismiss) {
28-
setVisible(false);
29-
} else {
24+
trigger: ({ dismiss }) => {
25+
if (dismiss) {
26+
return {
27+
props: {
28+
onPress: () => {
29+
setVisible(false);
30+
},
31+
},
32+
};
33+
}
34+
35+
return {
36+
props: {
37+
onPress: () => {
3038
setVisible((value) => !value);
31-
}
39+
},
40+
'aria-expanded': visible,
41+
'aria-controls': identifier,
3242
},
33-
'aria-expanded': visible,
34-
'aria-controls': identifier,
35-
},
36-
classes: cx(!visible && 'collapsed'),
37-
}),
43+
classes: cx(!visible && 'collapsed'),
44+
};
45+
},
3846
}),
3947
[visible],
4048
);

src/components/dropdowns/useDropdown.js

Lines changed: 23 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,31 @@ export default function useDropdown(
3333
identifier,
3434
visible,
3535
setVisible,
36-
trigger: ({ dismiss }) => ({
37-
props: {
38-
nativeID: identifier,
39-
ref: (element) => {
40-
controlRef.current = findNodeHandle(element);
41-
},
42-
onPress: () => {
43-
if (dismiss) {
44-
setVisible(false);
45-
} else {
36+
trigger: ({ dismiss }) => {
37+
if (dismiss) {
38+
return {
39+
props: {
40+
onPress: () => {
41+
setVisible(false);
42+
},
43+
},
44+
};
45+
}
46+
47+
return {
48+
props: {
49+
nativeID: identifier,
50+
ref: (element) => {
51+
controlRef.current = findNodeHandle(element);
52+
},
53+
onPress: () => {
4654
setVisible((value) => !value);
47-
}
55+
},
56+
'aria-haspopup': true,
57+
'aria-expanded': visible,
4858
},
49-
'aria-haspopup': true,
50-
'aria-expanded': visible,
51-
},
52-
}),
59+
};
60+
},
5361
menuRef: (element) => {
5462
menuRef.current = findNodeHandle(element);
5563
},

src/components/navbar/useNavbar.js

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,29 @@ export default function useNavbar(
2222
expanded,
2323
setExpanded,
2424
expand,
25-
trigger: ({ dismiss }) => ({
26-
props: {
27-
nativeID: identifier,
28-
onPress: () => {
29-
if (dismiss) {
30-
setExpanded(false);
31-
} else {
25+
trigger: ({ dismiss }) => {
26+
if (dismiss) {
27+
return {
28+
props: {
29+
onPress: () => {
30+
setExpanded(false);
31+
},
32+
},
33+
};
34+
}
35+
36+
return {
37+
props: {
38+
nativeID: identifier,
39+
onPress: () => {
3240
setExpanded((value) => !value);
33-
}
41+
},
42+
'aria-controls': identifier,
43+
'aria-expanded': expanded,
44+
'aria-label': 'Toggle navigation',
3445
},
35-
'aria-controls': identifier,
36-
'aria-expanded': expanded,
37-
'aria-label': 'Toggle navigation',
38-
},
39-
}),
46+
};
47+
},
4048
}),
4149
[expanded],
4250
);

0 commit comments

Comments
 (0)