Skip to content

Conversation

@ericspod
Copy link
Member

@ericspod ericspod commented Jun 6, 2025

Adresses the changelog item in #8421.

Description

This adds information to the changelog about what was done for 1.5.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

ericspod added 2 commits June 2, 2025 00:01
Signed-off-by: Eric Kerfoot <eric.kerfoot@gmail.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@gmail.com>
@ericspod ericspod requested review from KumoLiu and Nic-Ma June 6, 2025 10:27
@ericspod ericspod requested a review from Copilot June 6, 2025 10:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds detailed changelog entries for the 1.5.0 release, including supported dependency versions, the new MAISI version update, and a full list of added, fixed, changed, deprecated, and removed items.

  • Introduces the 1.5.0 section with release date and dependency policy
  • Describes the MAISI upgrade to maisi3d-rflow with performance and feature details
  • Updates the “What’s Changed” lists under Added, Fixed, Changed, Deprecated, and Removed
Comments suppressed due to low confidence (3)

CHANGELOG.md:10

  • Use ### for subheadings under the ## [1.5.0] section to maintain correct Markdown heading hierarchy.
## Supported Dependency Versions

CHANGELOG.md:20

  • The link text SPEC0 does not match the URL (spec-0000); rename the anchor to SPEC-0000 for consistency.
* Our support policy for other dependencies adheres for the most part to [SPEC0](https://scientific-python.org/specs/spec-0000), where dependency versions are supported where possible for up to two years.

CHANGELOG.md:49

  • [nitpick] Use a consistent verb tense (Add) in the Added list (* Add CODEOWNERS) to match the other entries.
* Adding CODEOWNERS (#8457)

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, leave two minor comments.

ericspod and others added 2 commits June 9, 2025 00:40
Signed-off-by: Eric Kerfoot <eric.kerfoot@gmail.com>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod
Copy link
Member Author

Hi @KumoLiu I think this is ready.

@KumoLiu
Copy link
Contributor

KumoLiu commented Jun 11, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) June 11, 2025 10:26
@KumoLiu KumoLiu merged commit dfe6fc7 into Project-MONAI:dev Jun 11, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants