Merge pull request #213 from PyO3/element-is-unsafe

Mark `Element` unsafe

Author: kngwyu

src/dtype.rs

@@ -169,7 +169,19 @@ impl DataType {
 }
 
 /// Represents that a type can be an element of `PyArray`.
-pub trait Element: Clone + Send {
+///
+/// Currently, only integer/float/complex types are supported.
+/// If you come up with a nice implementation for some other types, we're happy to receive your PR :)
+/// You may refer to the [numpy document](https://numpy.org/doc/stable/reference/c-api/dtype.html#enumerated-types)
+/// for all types that numpy supports.
+///
+/// # Safety
+///
+/// A type `T` that implements this trait should be safe when managed in numpy array,
+/// thus implementing this trait is marked unsafe.
+/// For example, we don't support `PyObject` because of [an odd segfault](https://github.com/PyO3/rust-numpy/pull/143),
+/// although numpy itself supports it.
+pub unsafe trait Element: Clone + Send {
     /// `DataType` corresponding to this type.
     const DATA_TYPE: DataType;
 
@@ -191,7 +203,7 @@ pub trait Element: Clone + Send {
 
 macro_rules! impl_num_element {
     ($t:ty, $npy_dat_t:ident $(,$npy_types: ident)+) => {
-        impl Element for $t {
+        unsafe impl Element for $t {
             const DATA_TYPE: DataType = DataType::$npy_dat_t;
             fn is_same_type(dtype: &PyArrayDescr) -> bool {
                 $(dtype.get_typenum() == NPY_TYPES::$npy_types as i32 ||)+ false