refactor: now mypy checks tests

Author: LeonidElkin

.pre-commit-config.yaml

@@ -66,4 +66,3 @@ repos:
           - numpy>=2
           - scipy>=1.13
           - pytest>=8
-        exclude: '^tests/.*'

pyproject.toml

@@ -93,6 +93,7 @@ exclude_lines = [
 ]
 
 [tool.mypy]
+files = [ "src", "tests" ]
 python_version = "3.12"
 strict = true
 warn_unused_configs = true
@@ -103,3 +104,10 @@ no_implicit_optional = true
 namespace_packages = true
 explicit_package_bases = true
 mypy_path = [ "src" ]
+
+[[tool.mypy.overrides]]
+module = [ "tests.*" ]
+disallow_untyped_defs = false
+check_untyped_defs = true
+warn_return_any = false
+implicit_reexport = true

tests/unit/families/test_basic.py

@@ -11,7 +11,10 @@ class TestBaseFamily:
     CDF: GenericCharacteristicName = "cdf"
     PPF: GenericCharacteristicName = "mean"
 
-    def make_default_family(self, distr_characteristics=None) -> ParametricFamily:
+    def make_default_family(
+        self,
+        distr_characteristics: dict[GenericCharacteristicName, dict[str, object]] | None = None,
+    ) -> ParametricFamily:
         if distr_characteristics is None:
             distr_characteristics = {
                 self.PDF: {"base": lambda p, x: x},
@@ -22,7 +25,7 @@ def make_default_family(self, distr_characteristics=None) -> ParametricFamily:
             name="Default",
             distr_type=UnivariateContinuous,
             distr_parametrizations=["base", "alt"],
-            distr_characteristics=distr_characteristics,
+            distr_characteristics=distr_characteristics,  # type: ignore[arg-type]
             sampling_strategy=MockSamplingStrategy(),
         )
 
@@ -35,6 +38,6 @@ class Alt(Parametrization):
             value: float
 
             def transform_to_base_parametrization(self) -> Parametrization:
-                return Base(value=self.value)
+                return Base(value=self.value)  # type: ignore[call-arg]
 
         return fam

tests/unit/families/test_distribution_cache.py

@@ -33,12 +33,12 @@ def test_cache_auto_invalidation(self) -> None:
         assert computations1 is computations1_again  # cache hit
 
         # Replacing with a *new* object of the same parametrization should rebuild the cache
-        distribution.parameters = family.parametrizations["alt"](value=5.0)
+        distribution.parameters = family.parametrizations["alt"](value=5.0)  # type: ignore[call-arg]
         computations2 = distribution.analytical_computations
         assert computations2 is not computations1
 
         # Switching to the base parametrization should also rebuild the cache
-        distribution.parameters = family.parametrizations["base"](value=7.0)
+        distribution.parameters = family.parametrizations["base"](value=7.0)  # type: ignore[call-arg]
         computations3 = distribution.analytical_computations
         assert computations3 is not computations2
 

tests/unit/families/test_parameters.py

@@ -1,16 +1,16 @@
 from __future__ import annotations
 
-import pytest
+from typing import Any
 
 from pysatl_core.families import (
     ParametricFamily,
     Parametrization,
     ParametrizationConstraint,
     constraint,
-    parametrization,
 )
 from pysatl_core.types import UnivariateContinuous
 from tests.unit.families.test_basic import TestBaseFamily
+from tests.utils.mocks import MockSamplingStrategy
 
 
 class TestParametrizationAPI(TestBaseFamily):
@@ -30,7 +30,7 @@ def test_constraint_decorator_marks_function(self) -> None:
         """Decorator should tag a function so Parametrization.validate() can discover it."""
 
         @constraint("Value must be positive")
-        def check_positive(self) -> bool:  # noqa: ANN001 (test signature)
+        def check_positive(self: Any) -> bool:  # noqa: ANN001 (test signature)
             return getattr(self, "value", 0) > 0
 
         # Different code versions may use single or double underscore attributes.
@@ -52,42 +52,7 @@ def test_free_function_parametrization_decorator(self) -> None:
             distr_type=UnivariateContinuous,
             distr_parametrizations=["base"],
             distr_characteristics={},
-            sampling_strategy=lambda n, d, **_: __import__("numpy").random.random((n, 1)),  # type: ignore[assignment]
-            computation_strategy=lambda: None,  # type: ignore[assignment]
-        )
-
-        @parametrization(family=family, name="base")
-        class Base(Parametrization):
-            value: float
-
-            @constraint("Value must be positive")
-            def check_positive(self) -> bool:
-                return self.value > 0
-
-        instance = Base(value=5.0)  # type: ignore[call-arg]
-        assert instance.name == "base"
-        assert instance.parameters == {"value": 5.0}
-        assert getattr(Base, "__family__", None) is family
-        assert getattr(Base, "__param_name__", None) == "base"
-        assert hasattr(Base, "__dataclass_fields__")
-
-        # Validation succeeds
-        instance.validate()
-
-        # Validation fails
-        invalid = Base(value=-1.0)  # type: ignore[call-arg]
-        with pytest.raises(ValueError, match="Constraint.*does not hold"):
-            invalid.validate()
-
-    def test_method_style_parametrization_decorator(self) -> None:
-        """family.parametrization(name=...) should behave the same as the free decorator."""
-        family = ParametricFamily(
-            name="MethodDecoratorFamily",
-            distr_type=UnivariateContinuous,
-            distr_parametrizations=["kind"],
-            distr_characteristics={},
-            sampling_strategy=lambda n, d, **_: __import__("numpy").random.random((n, 1)),  # type: ignore[assignment]
-            computation_strategy=lambda: None,  # type: ignore[assignment]
+            sampling_strategy=MockSamplingStrategy(),
         )
 
         @family.parametrization(name="kind")
@@ -118,4 +83,4 @@ def test_get_base_parameters_uses_family_logic(self) -> None:
         base_from_alt = family.get_base_parameters(alt_params)
         assert isinstance(base_from_alt, BaseCls)
         # Our default factory maps Alt(value=v) → Base(value=v)
-        assert base_from_alt.value == 3.0
+        assert base_from_alt.value == 3.0  # type: ignore[attr-defined]