Add inputs argument to ScriptRunner

[takumi-miyajima]

Is your feature request related to a problem? Please describe.
Parameter configuration is currently limited to .toml files only, which makes programmatic parameter passing difficult.

Describe the solution you'd like
I would like to be able to pass parameters as arguments directly to the script runner, allowing for more flexible parameter configuration.

"""
@pyne
"""

from pynecore.lib import input

def main(
    short_length: int = input.int(5),
    long_length: int = input.int(10),
):

import pathlib

from pynecore.core.script_runner import ScriptRunner


def run(
    script_path: pathlib.Path,
    plot_path: pathlib.Path,
    strat_path: pathlib.Path,
    trade_path: pathlib.Path,
    ohlcv_iter,
    syminfo,
):
    runner: ScriptRunner = ScriptRunner(
        script_path=script_path,
        plot_path=plot_path,
        strat_path=strat_path,
        trade_path=trade_path,
        ohlcv_iter=ohlcv_iter,
        syminfo=syminfo,
        inputs={"short_length": 10, "long_length": 20}  # <- arguments directly
    )
    runner.run_iter()

Describe alternatives you've considered
Using the internal old_input_values variable as a workaround:

import pathlib

from pynecore.core.script_runner import ScriptRunner

from pynecore.core.script import old_input_values
from typing import Any

def run(
    script_path: pathlib.Path,
    plot_path: pathlib.Path,
    strat_path: pathlib.Path,
    trade_path: pathlib.Path,
    ohlcv_iter,
    syminfo,
):
    inputs = {"short_length": 5, "long_length": 10}
    _inject_arguments_directly(inputs)  # <- workaround

    runner: ScriptRunner = ScriptRunner(
        script_path=script_path,
        plot_path=plot_path,
        strat_path=strat_path,
        trade_path=trade_path,
        ohlcv_iter=ohlcv_iter,
        syminfo=syminfo,
    )
    runner.run_iter()


def _inject_arguments_directly(script_args: dict[str, Any]):
    for key, value in script_args.items():
        old_input_values[key] = value
        old_input_values[key + "__global__"] = value


# src/pynecore/core/script.py
# for arg_name, arg_data in data['inputs'].items():
#     if 'value' not in arg_data:
#         continue
#     old_input_values[arg_name] = arg_data['value']
#     old_input_values[arg_name + '__global__'] = arg_data['value']  # For strict mode

Additional context
Thank you for creating such an excellent library.

[wallneradam]

Thanks, it is a good idea.

[takumi-miyajima]

Here is an additional feature request.

It would be great if the script could run even without an input class, as shown below.
The reason is that this would allow the function to accept Python data (like dict) that isn't restricted by the pinescript specifications.

I'm not an expert in Python, so I'm not sure about the best way to implement this, but it seems possible to get the argument definitions using from inspect import signature.

"""
@pyne
"""


def main(
    economic: dict[str, Any] = {}  # <- Allows defining arguments without using an `input class`
):

As a current workaround, the following code partially achieves this.
Since this is not a clean method, it would be appreciated if the library could support this feature natively.

"""
@pyne
"""


from pynecore.lib import input, time

def main(
    economic=input.__dict__
):
    print(economic)

    print(economic.get(str(time)))  # -> {'[US] employment statistics': 'HIGH'}

import pathlib
from typing import Any, Iterable

from pynecore import lib
from pynecore.core import syminfo
from pynecore.core.script import old_input_values
from pynecore.core.script_runner import ScriptRunner
from pynecore.types import ohlcv


def run(
    script_path: pathlib.Path,
    plot_path: pathlib.Path,
    trade_path: pathlib.Path,
    ohlcv_iter: Iterable[ohlcv.OHLCV],
    syminfo: syminfo.SymInfo,
    last_bar_index: int,
    inputs: dict[str, Any],
) -> None:
    _inject_arguments_directly(inputs)

    _inject_into_input_object(
        {"economic": {1752473760000: {"[US] employment statistics": "HIGH"}}}
    )

    runner: ScriptRunner = ScriptRunner(
        script_path=script_path,
        plot_path=plot_path,
        strat_path=None,
        trade_path=trade_path,
        ohlcv_iter=ohlcv_iter,
        syminfo=syminfo,
        last_bar_index=last_bar_index,
    )

    results = list(runner.run_iter())


def _inject_arguments_directly(script_args: dict[str, Any]) -> None:
    for key, value in script_args.items():
        old_input_values[key] = value
        old_input_values[key + "__global__"] = value


def _inject_into_input_object(script_args: dict[str, Any]) -> None:  # <- Workaround
    for _, value in script_args.items():
        for key, value in value.items():
            setattr(lib.input, str(key), value)