Add content retrieval logic #24
Conversation
|
|
src/requests.ts
Outdated
|
|
||
| if (response.data) { | ||
| // listing the contents of a directory | ||
| if (options.path.indexOf('.') === -1) { |
There was a problem hiding this comment.
If there is no . character in the given path ... do the following.
Could you please clarify this? I'm not sure I understand why the . matters?
There was a problem hiding this comment.
The check is supposed to be for whether the given path corresponds to a directory or a file. I pushed a commit to better reflect this:
const isDir: boolean = PathExt.extname(options.path) === '';
There was a problem hiding this comment.
Is there a way to check if it has children, instead? Because there could be directories with . in the name, right? The filesystem (and S3 I imagine) allow for this.
There was a problem hiding this comment.
For example, in every git repo, there is a root directory called .git
There was a problem hiding this comment.
Great point! I pushed a commit which updates the logic to check in the backend whether we are dealing with a directory or a file. The problem gets more complex when dealing with empty files or directories, so we will have to come back to this.
Co-authored-by: Afshin Taylor Darian <git@darian.link>
|
Going ahead and merging this. We can come back with a follow up PR to improve the logic for listing directories. |
2 participants
This PR adds the logic to list the contents of a drive and retrieve the contents of an individual file.
In order to properly deal with all types of content, the extension also retrieves all the registered
JupyterLabfile types and their corresponding formats and mimetypes. For certain files media types, the content is decoded differently in the backend.