Respond to comments, update tests

Author: kshyatt

Project.toml

@@ -55,6 +55,3 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [targets]
 test = ["Aqua", "JET", "SafeTestsets", "Test", "TestExtras", "ChainRulesCore", "ChainRulesTestUtils", "StableRNGs", "Zygote", "CUDA", "AMDGPU", "GenericLinearAlgebra", "GenericSchur", "Mooncake"]
-
-[sources]
-CUDA = {url="https://github.com/juliagpu/cuda.jl", rev="master"}

ext/MatrixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl

@@ -143,7 +143,7 @@ MatrixAlgebraKit.isantihermitian_exact(A::Diagonal{T, <:StridedROCVector{T}}) wh
 MatrixAlgebraKit.isantihermitian_approx(A::StridedROCMatrix; kwargs...) =
     @invoke MatrixAlgebraKit.isantihermitian_approx(A::Any; kwargs...)
 function MatrixAlgebraKit.isantihermitian_approx(A::Diagonal{T, <:StridedROCVector{T}}; atol, rtol, kwargs...) where {T <: Real}
-    return norm(A) ≤ max(atol, rtol)
+    return norm(A) ≤ atol
 end
 
 function MatrixAlgebraKit._avgdiff!(A::StridedROCMatrix, B::StridedROCMatrix)

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

@@ -168,7 +168,7 @@ MatrixAlgebraKit.isantihermitian_exact(A::Diagonal{T, <:StridedCuVector{T}}) whe
 MatrixAlgebraKit.isantihermitian_approx(A::StridedCuMatrix; kwargs...) =
     @invoke MatrixAlgebraKit.isantihermitian_approx(A::Any; kwargs...)
 function MatrixAlgebraKit.isantihermitian_approx(A::Diagonal{T, <:StridedCuVector{T}}; atol, rtol, kwargs...) where {T <: Real}
-    return norm(A) ≤ max(atol, rtol)
+    return norm(A) ≤ atol
 end
 
 function MatrixAlgebraKit._avgdiff!(A::StridedCuMatrix, B::StridedCuMatrix)

test/amd/projections.jl

@@ -32,9 +32,12 @@ const BLASFloats = (Float32, Float64, ComplexF32, ComplexF64)
             @test isantihermitian(Ba)
             @test Ba ≈ Aa
             @test A == Ac
+            # this is still hermitian for real Diagonals!
             Ba_approx = Ba + noisefactor * Ah
             @test !isantihermitian(Ba_approx)
-            @test isantihermitian(Ba_approx; rtol = 10 * noisefactor)
+            if !isa(A, Diagonal) && !(T <: Real)
+                @test isantihermitian(Ba_approx; rtol = 10 * noisefactor)
+            end
 
             Bh = project_hermitian!(Ac, alg)
             @test Bh === Ac

test/cuda/projections.jl

@@ -34,7 +34,10 @@ const BLASFloats = (Float32, Float64, ComplexF32, ComplexF64)
             @test A == Ac
             Ba_approx = Ba + noisefactor * Ah
             @test !isantihermitian(Ba_approx)
-            @test isantihermitian(Ba_approx; rtol = 10 * noisefactor)
+            # this is still hermitian for real Diagonals!
+            if !isa(A, Diagonal) && !(T <: Real)
+                @test isantihermitian(Ba_approx; rtol = 10 * noisefactor)
+            end
 
             Bh = project_hermitian!(Ac, alg)
             @test Bh === Ac