Implement DiagonalAlgorithms for the GPU
#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
reviewed
Dec 2, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I might be missing something obvious, but there doesn't seem to be any specific specializations for the different diagonal algorithm types. Does that mean we can simply take the other changes as small fixes and use DiagonalAlgorithm for all of them?
Member
Author
|
Yeah, I did it this way for now to see if we did need them specialized, but seems not. (Thus, WIP.) I'll update the PR. |
kshyatt
force-pushed
the
ksh/gpudiag
branch
6 times, most recently
from
607be21 to
eff9275
Compare
lkdvos
reviewed
Dec 2, 2025
lkdvos
reviewed
Dec 2, 2025
lkdvos
reviewed
Dec 2, 2025
lkdvos
reviewed
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Dec 2, 2025
lkdvos
changed the title
DiagonalAlgorithms for the GPUDiagonalAlgorithms for the GPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to try doing these as separate algos for each backend, as I think AMDGPU.jl does not support
sortpermyet (but CUDA.jl does).