Change to isunit for GenericUnit (#38)

* change `isunit` for `GenericUnit`

* add tests

* minor change

* add `leftunit` and `rightunit` for product sectors w/ tests

* remove old todo

* bump version

Author: borisdevos

Project.toml

@@ -1,7 +1,7 @@
 name = "TensorKitSectors"
 uuid = "13a9c161-d5da-41f0-bcbd-e1a08ae0647f"
 authors = ["Lukas Devos", "Jutho Haegeman"]
-version = "0.3.2"
+version = "0.3.3"
 
 [deps]
 HalfIntegers = "f0d1745a-41c9-11e9-1dd9-e5d34d218721"

src/product.jl

@@ -69,6 +69,12 @@ function allunits(::Type{ProductSector{T}}) where {T}
     iterators = map(allunits, _sectors(T))
     return SectorSet{ProductSector{T}}(Base.Iterators.product(iterators...))
 end
+function leftunit(a::P) where {P <: ProductSector}
+    return P(map(leftunit, a.sectors))
+end
+function rightunit(a::P) where {P <: ProductSector}
+    return P(map(rightunit, a.sectors))
+end
 
 dual(p::ProductSector) = ProductSector(map(dual, p.sectors))
 function ⊗(p1::P, p2::P) where {P <: ProductSector}

src/sectors.jl

@@ -128,7 +128,7 @@ function isunit(a::Sector)
     return if UnitStyle(a) === SimpleUnit()
         a == unit(a)
     else
-        leftunit(a) == a == rightunit(a)
+        a in allunits(typeof(a))
     end
 end
 Base.isone(a::Sector) = isunit(a)
@@ -328,7 +328,7 @@ This can be either
 *   `SimpleUnit()`: the unit is simple (e.g. fusion categories);
 *   `GenericUnit()`: the unit is semisimple.
 """
-abstract type UnitStyle end #TODO: rename
+abstract type UnitStyle end
 UnitStyle(a::Sector) = UnitStyle(typeof(a))
 
 struct SimpleUnit <: UnitStyle end

test/multifusion.jl

@@ -36,6 +36,15 @@ Istr = TensorKitSectors.type_repr(I)
         @test length(allunits(I)) == 2
         @test allunits(I) == (C0, D0)
 
+        @test !isunit(C0 ⊠ C1)
+        @test !isunit(C0 ⊠ D1)
+        @test isunit(C0 ⊠ C0)
+        @test isunit(D0 ⊠ D0)
+        @test isunit(C0 ⊠ D0)
+        @test length(allunits(I ⊠ I)) == 4
+
+        @test leftunit(M ⊠ Mop) == C0 ⊠ D0 == rightunit(Mop ⊠ M)
+
         @test eval(Meta.parse(sprint(show, s))) == s
         @test @constinferred(hash(s)) == hash(deepcopy(s))
         @constinferred dual(s)

test/runtests.jl

@@ -63,6 +63,7 @@ end
         @test typeof(a ⊠ b) == I1 ⊠ I2
 
         @test @constinferred(length(allunits(I1 ⊠ I2))) == 1
+        @test @constinferred(unit(I1 ⊠ I2)) == leftunit(a ⊠ b) == rightunit(a ⊠ b)
     end
     @test @constinferred(Tuple(SU2Irrep(1) ⊠ U1Irrep(0))) == (SU2Irrep(1), U1Irrep(0))
     @test @constinferred(length(FermionParity(1) ⊠ SU2Irrep(1 // 2) ⊠ U1Irrep(1))) == 3

test/testsetup.jl

@@ -30,7 +30,7 @@ function randsector(::Type{I}) where {I <: Sector}
     end
     return a
 end
-randsector(::Type{I}) where {I <: Union{Trivial, PlanarTrivial}} = one(I)
+randsector(::Type{I}) where {I <: Union{Trivial, PlanarTrivial}} = unit(I)
 
 function hasfusiontensor(I::Type{<:Sector})
     try