-
-
Notifications
You must be signed in to change notification settings - Fork 6
Fix Text Overflow in Copilot Display #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
google-labs-jules
wants to merge
1
commit into
main
Choose a base branch
from
fix-text-overflow-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,3 +34,6 @@ yarn-error.log* | |
| # typescript | ||
| *.tsbuildinfo | ||
| next-env.d.ts | ||
|
|
||
| # logs | ||
| *.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing
truncatewithbreak-wordswill allow wrapping, but it also removes the single-line constraint and ellipsis behavior entirely. Depending on the layout, a very long query could now expand the card vertically a lot and potentially push other UI elements down in an undesirable way.If the design intent is to keep things compact while still preventing horizontal overflow, you might want to combine classes to both limit lines and allow wrapping (e.g., using a
line-clamp-*utility if available) rather than fully unbounded wrapping. Otherwise, this change trades one UI issue (overflow) for another (unbounded height).Suggestion
Consider constraining the text to a small number of lines while still permitting wrapping, for example by using a line clamp utility if your Tailwind setup includes it, such as
line-clamp-2 break-words, so the card doesn't grow arbitrarily tall for long inputs:If your design system prefers a different max-line behavior, adjust the clamp value accordingly. Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this change or a variant tailored to your Tailwind configuration.