Refactor

Author: mostlyobvious

ruby_event_store/lib/ruby_event_store/specification.rb

@@ -22,7 +22,7 @@ class Specification
       ) do
         def limit? = !limit.infinite?
         def with_ids? = !with_ids.nil?
-        def with_types? = !(with_types || []).empty?
+        def with_types? = !with_types.nil?
         def forward? = direction.equal?(:forward)
         def backward? = direction.equal?(:backward)
         def batched? = read_as.equal?(:batch)
@@ -313,7 +313,8 @@ def last
     # @types [Class, Array(Class)] types of event to look for.
     # @return [Specification]
     def of_type(*types)
-      Specification.new(reader, result.with(with_types: types.flatten.map(&:to_s)))
+      types_ = types.flatten.map(&:to_s) unless types.empty?
+      Specification.new(reader, result.with(with_types: types_))
     end
     alias of_types of_type
 

ruby_event_store/spec/specification_spec.rb

@@ -68,6 +68,7 @@ module RubyEventStore
     specify { expect(specification.with_id([]).result.with_ids?).to be(true) }
 
     specify { expect(specification.result.with_types).to be_nil }
+    specify { expect(specification.of_type.result.with_types).to be_nil }
     specify { expect(specification.of_type([TestEvent]).result.with_types).to eq(["TestEvent"]) }
     specify { expect(specification.result.with_types?).to be(false) }
     specify { expect(specification.of_type([TestEvent]).result.with_types?).to be(true) }