Breaking internals is not breaking

Author: mostlyobvious

ruby_event_store/lib/ruby_event_store/specification.rb

@@ -22,7 +22,7 @@ class Specification
       ) do
         def limit? = !limit.infinite?
         def with_ids? = !with_ids.nil?
-        def with_types? = !with_types.nil?
+        def with_types? = !with_types.empty?
         def forward? = direction.equal?(:forward)
         def backward? = direction.equal?(:backward)
         def batched? = read_as.equal?(:batch)
@@ -53,7 +53,7 @@ def initialize(
         read_as: :all,
         batch_size: DEFAULT_BATCH_SIZE,
         with_ids: nil,
-        with_types: nil,
+        with_types: [],
       )
     )
       @reader = reader
@@ -313,8 +313,7 @@ def last
     # @types [Class, Array(Class)] types of event to look for.
     # @return [Specification]
     def of_type(*types)
-      types_ = types.flatten.map(&:to_s) unless types.empty?
-      Specification.new(reader, result.with(with_types: types_))
+      Specification.new(reader, result.with(with_types: types.flatten.map(&:to_s)))
     end
     alias of_types of_type
 

ruby_event_store/spec/specification_spec.rb

@@ -67,8 +67,8 @@ module RubyEventStore
     specify { expect(specification.with_id([event_id]).result.with_ids?).to be(true) }
     specify { expect(specification.with_id([]).result.with_ids?).to be(true) }
 
-    specify { expect(specification.result.with_types).to be_nil }
-    specify { expect(specification.of_type.result.with_types).to be_nil }
+    specify { expect(specification.result.with_types).to eq([]) }
+    specify { expect(specification.of_type.result.with_types).to eq([]) }
     specify { expect(specification.of_type([TestEvent]).result.with_types).to eq(["TestEvent"]) }
     specify { expect(specification.result.with_types?).to be(false) }
     specify { expect(specification.of_type([TestEvent]).result.with_types?).to be(true) }