Skip to content

Commit 1264613

Browse files
committed
change tag selection layout for better reachability
1 parent 01126d8 commit 1264613

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

features/feature_dialogs/src/main/java/com/example/util/simpletimetracker/feature_dialogs/recordTagSelection/RecordTagSelectionDialogFragment.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
package com.example.util.simpletimetracker.feature_dialogs.recordTagSelection
22

3+
import com.example.util.simpletimetracker.feature_dialogs.databinding.RecordTagSelectionDialogFragmentBinding as Binding
34
import android.os.Bundle
45
import android.view.LayoutInflater
56
import android.view.ViewGroup
67
import androidx.fragment.app.commit
78
import com.example.util.simpletimetracker.core.base.BaseBottomSheetFragment
89
import com.example.util.simpletimetracker.core.dialog.OnTagSelectedListener
9-
import com.example.util.simpletimetracker.core.extension.setFullScreen
1010
import com.example.util.simpletimetracker.core.extension.setSkipCollapsed
1111
import com.example.util.simpletimetracker.core.utils.fragmentArgumentDelegate
1212
import com.example.util.simpletimetracker.feature_dialogs.R
1313
import com.example.util.simpletimetracker.navigation.ScreenFactory
1414
import com.example.util.simpletimetracker.navigation.params.screen.RecordTagSelectionParams
1515
import dagger.hilt.android.AndroidEntryPoint
1616
import javax.inject.Inject
17-
import com.example.util.simpletimetracker.feature_dialogs.databinding.RecordTagSelectionDialogFragmentBinding as Binding
1817

1918
@AndroidEntryPoint
2019
class RecordTagSelectionDialogFragment :
@@ -37,7 +36,6 @@ class RecordTagSelectionDialogFragment :
3736

3837
override fun initDialog() {
3938
setSkipCollapsed()
40-
setFullScreen()
4139
}
4240

4341
override fun initUi() {

features/feature_dialogs/src/main/res/layout/record_tag_selection_dialog_fragment.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
android:id="@+id/containerRecordTagSelection"
1818
android:layout_width="match_parent"
1919
android:layout_height="0dp"
20-
android:layout_marginTop="32dp"
20+
android:layout_marginTop="16dp"
2121
android:layout_weight="1" />
2222

2323
</androidx.appcompat.widget.LinearLayoutCompat>

features/feature_tag_selection/src/main/res/layout/record_tag_selection_fragment.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
<androidx.recyclerview.widget.RecyclerView
99
android:id="@+id/rvRecordTagSelectionList"
1010
android:layout_width="match_parent"
11-
android:layout_height="0dp"
11+
android:layout_height="wrap_content"
12+
android:layout_marginBottom="16dp"
13+
app:layout_constrainedHeight="true"
1214
app:layout_constraintBottom_toTopOf="@id/btnRecordTagSelectionSave"
1315
app:layout_constraintTop_toTopOf="parent"
16+
tools:itemCount="10"
1417
tools:listitem="@layout/item_category_layout" />
1518

1619
<com.google.android.material.button.MaterialButton

0 commit comments

Comments
 (0)