handle all error cases

Author: mzanoni

lib/src/relewise.client.ts

@@ -5,6 +5,28 @@ export interface RelewiseClientOptions {
     serverUrl?: string;
 }
 
+export class ProblemDetailsError extends Error {
+    private _details?: HttpProblemDetails;
+
+    public get details(): HttpProblemDetails | undefined {
+        return this._details;
+    }
+
+    constructor(message: string, details?: HttpProblemDetails) {
+        super(message);
+        this._details = details;
+    }
+}
+
+export interface HttpProblemDetails {
+    type: string;
+    title: string;
+    status: number;
+    traceId: string;
+    detail?: string;
+    errors?: Record<string, string>;
+}
+
 export abstract class RelewiseClient {
     private readonly _serverUrl: string = 'https://api.relewise.com';
     private readonly _urlPath: string = 'v1';
@@ -36,13 +58,18 @@ export abstract class RelewiseClient {
             body: JSON.stringify(data),
         });
 
+        if (!response.ok) {
+            let responseMessage = null;
+            try { responseMessage = await response.json(); } catch (_) { console.log(responseMessage)}
+
+            throw new ProblemDetailsError('Error when calling the Relewise API. Read more in the details property if there is error response or look in the network tab.', responseMessage);
+        }
+
         try {
             const responseMessage = await response.json();
-            
-            if (response.ok) return responseMessage as TResponse;
 
-            throw responseMessage as ProblemDetailsError
-        } catch(err) {
+            return responseMessage as TResponse;
+        } catch (err) {
             return undefined;
         }
     }
@@ -53,13 +80,4 @@ export abstract class RelewiseClient {
             ? baseUrl.concat(joinedSegments)
             : baseUrl.concat('/', joinedSegments);
     }
-}
-
-export interface ProblemDetailsError  {
-    type: string;
-    title: string;
-    status: number;
-    traceId: string;
-    detail?: string;
-    errors?: Record<string, string>;
 }

lib/tests/integration-tests/tracker.integration.test.ts

@@ -170,25 +170,29 @@ test('Track Product View with invalid key', async() => {
         productId: '2',
         user: UserFactory.anonymous(),
     }).catch((e) => {
-        console.log(e.message)
         expect(e).toBeDefined();
-        expect((e as ProblemDetailsError).title ).toEqual('Unauthorized1');
-        expect((e as any).fake ).toBeDefined();
-        expect(e).toMatch('error');
+        expect((e as ProblemDetailsError).details?.title ).toEqual('Unauthorized');
+        expect(e.message).toEqual('Error when calling the Relewise API. Read more in the details property if there is error response or look in the network tab.')
     });
 });
 
 test('Track Product View without id', async() => {
+    await expect(async() => {
+        return await tracker.trackProductView({
+            productId: null,
+            user: UserFactory.anonymous(),
+        } as any)
+    }).rejects.toThrow();
+});
 
+test('Track Product View without id', async() => {
     try {
         await tracker.trackProductView({
             productId: null,
             user: UserFactory.anonymous(),
         } as any);
-    } catch (e) {
-
+    }
+    catch (e) {
         expect(e).toBeDefined();
-        expect(e).toMatch('error');
-        
     }
 });