-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Description
Issue description
When configurable product SKUs have double-quotes in them (although I realize double-quotes in SKUs are not ideal, that is what exists), then the richSnippet JS breaks. See screenshot below.
I think the most ideal solution would be to replace the double-quotes in the SKU data attribute in \Reviewscouk\Reviews\Block\Richsnippet::getRichSnippet
with "template literals" (backticks). This is already done with the description.
If this is an acceptable solution, I can create a PR. Thanks.
Steps to reproduce the issue
- Create a configurable product with a SKU that contains a double-quote.
- Navigate to that PDP.
What's the expected result?
- No JS errors
What's the actual result?
- The following JS error shows in the console:
Uncaught SyntaxError: Unexpected token ';' (at sample-url:2347:323)
Additional details / screenshot
Metadata
Metadata
Assignees
Labels
No labels