Add get_value_sum and tests.

Clean up code a bit.

Author: Tomasz-Kluczkowski

data_extractor.py

@@ -1,24 +1,22 @@
-from websites.resources.data import WEBSITES
-
-
 class DataExtractor:
     """
-    Use to extract, cleanse and amend incorrect website data collection.
+    Use to extract, cleanse, sum and amend incorrect website data collection.
     """
     def __init__(self, data):
         self.data = data
 
     def find_items(self, value=4):
         """
-        Find and return a new list of items where key "value" is greater than or equal to parameter value. Default = 4.
+        Find and return a new list of items where key "value" is greater than or equal to parameter value.
+        :param value: int, value to find items for, default = 4.
         :return: list(dict), list of dictionaries matching the above filtering rule.
         """
         return [item for item in self.data if item.get('value') and item.get('value') >= value]
 
     def amend_domain_values(self, prefix='www.'):
         """
         Fixes missing parts of the domain names.
-        :param prefix: str, prefix to add to the domain name. Default = 'www'.
+        :param prefix: str, prefix to add to the domain name, default = 'www'.
         :return: amended: list(dict), amended list of web records.
         """
         amended = []
@@ -39,18 +37,17 @@ def cleanse_data(self):
             url = item.get('url')
             secure = item.get('secure')
             # https marked as secure = False
-            if url and url.startswith('https:') and not item.get('secure'):
+            if url and url.startswith('https:') and not secure:
                 item['secure'] = True
             # http marked as secure = True
-            elif url and url.startswith('http:') and item.get('secure'):
+            elif url and url.startswith('http:') and secure:
                 item['secure'] = False
             amended.append(item)
         return amended
 
-
-
-# data_extractor = DataExtractor(WEBSITES)
-# print(data_extractor.amend_domain_values())
-# print(data_extractor.find_items(4))
-# print(len(data_extractor.find_items(4)))
-# print(data_extractor.cleanse_data())
+    def get_value_sum(self):
+        """
+        Returns sum of all value keys in the data set.
+        :return: int, sum of all value keys in the data set.
+        """
+        return sum([item.get('value', 0) for item in self.data])

tests/test_data_extractor.py

@@ -1,4 +1,6 @@
-import pytest
+# Tests are written for pytest framework.
+# use: pip install pytest
+# to test: pytest
 
 from data_extractor import DataExtractor
 from websites.resources.data import WEBSITES
@@ -172,3 +174,10 @@ def test_cleanse_data(self):
         ]
         _data_extractor = DataExtractor(test_data)
         assert _data_extractor.cleanse_data() == expected
+
+    def test_get_value_sum(self):
+        assert data_extractor.get_value_sum() == 23
+
+    def test_get_value_sum_empty_data_set(self):
+        _data_extractor = DataExtractor([])
+        assert _data_extractor.get_value_sum() == 0