Handle pylint warnings

Author: f-PLT

climateset/download/constants/input4mips.py

@@ -1,6 +1,7 @@
 # TODO add VAR_SOURCE_LOOKUP with raw variables
 # TODO add supported experiments
 # TODO do we really need emission endings, meta_endings_prc, meta_endings_shar?? how is this used so far?
+# pylint: disable=C0103
 from dataclasses import dataclass
 from typing import Final
 

climateset/download/downloader_config.py

@@ -199,7 +199,7 @@ def _generate_plain_emission_vars(self):
             for b in self.biomass_vars:
                 try:
                     self.variables.remove(b)
-                except Exception as error:
+                except Exception as error:  # pylint: disable=W0718
                     self.logger.warning(f"Caught the following exception but continuing : {error}")
 
         self.meta_vars_percentage = [

climateset/download/utils.py

@@ -93,7 +93,7 @@ def infer_nominal_resolution(ds: xr.Dataset, nominal_resolution: str, logger: lo
         degree = abs(ds.lon[0].item() - ds.lon[1].item())
         nom_res = int(degree * 100)
         logger.info(f"Inferring nominal resolution: {nom_res}")
-    except Exception as error:
+    except Exception as error:  # pylint: disable=W0718
         logger.warning(f"Caught the following exception but continuing : {error}")
     return nom_res
 

pyproject.toml

@@ -39,7 +39,7 @@ pre-commit = "^3.7.0"
 flake8-pyproject = "^1.2.3"
 black = "^24.4.2"
 nox = "^2024.4.15"
-docformatter = {extras = ["tomli"], version = "^1.7.5"}
+docformatter = { extras = ["tomli"], version = "^1.7.5" }
 autoflake = "^2.3.1"
 autopep8 = "^2.3.2"
 ruff = "^0.11.11"
@@ -101,7 +101,15 @@ replace = '''
 '''
 
 [tool.pylint]
-disable = "C0114,C0115,C0116,R0903,R1710,W1203"
+disable = [
+    "C0114",
+    "C0115",
+    "C0116",
+    "R0903",
+    "R1710",
+    "W1203",
+    "W0511", # TO DO warnings
+]
 max-line-length = 120
 max-locals = 20
 max-args = 16
@@ -160,49 +168,49 @@ line-length = 120
 target-version = "py311"
 
 exclude = [
-  ".git",
-  "migrations",
-  "__pycache__",
+    ".git",
+    "migrations",
+    "__pycache__",
 ]
 
 [tool.ruff.lint]
 select = [
-    "A",   # Flake8 Built ins
-    "E",   # Error (Flake8)
-    "F",   # Pyflakes (Flake8)
-    "W",   # Warning (Flake8)
-    "I",   # isort (import sorting)
-    "N",   # Naming conventions (Pylint, etc.)
+    "A", # Flake8 Built ins
+    "E", # Error (Flake8)
+    "F", # Pyflakes (Flake8)
+    "W", # Warning (Flake8)
+    "I", # isort (import sorting)
+    "N", # Naming conventions (Pylint, etc.)
     "C90", # mccabe complexity (replaces flake8 --max-complexity and mccabe)
-    "B",   # Bugbear (common linting issues)
-    "UP",  # pyupgrade (suggests modern Python syntax)
+    "B", # Bugbear (common linting issues)
+    "UP", # pyupgrade (suggests modern Python syntax)
     "PLR", # Pylint refactor
     "PLE", # Pylint error (specific Pylint error rules)
     "PLW", # Pylint warning (specific Pylint warning rules)
     "PLC", # Pylint convention (specific Pylint convention rules)
-    "R",   # Refactor (Pylint refactoring suggestions)
+    "R", # Refactor (Pylint refactoring suggestions)
     "TID", # TO DO comments
-    "FAST",# FastAPI
-    "C4",  # List and dict comprehensions
-    "DJ",  # Django
+    "FAST", # FastAPI
+    "C4", # List and dict comprehensions
+    "DJ", # Django
     "PIE", # Returns and unecessary returns
-    "Q",   # Double quotes
+    "Q", # Double quotes
     "RET", # Fix return statements
     "PTH", # Enforce pathlib
     "ARG", # Unused argument
     "FLY", # Flynt
     "NPY", # Numpy specific
-    "PD",  # Pandas specific
+    "PD", # Pandas specific
     "RUF", # Ruff specific
 ]
 
 ignore = [
-  "E203",  # whitespace before ':', Black already handles this
-  "E266",  # too many leading '#' for comments
-  "E501",  # line too long (we enforce via line-length instead)
-  "RET504",
-  "RUF013",
-  "PTH123"
+    "E203", # whitespace before ':', Black already handles this
+    "E266", # too many leading '#' for comments
+    "E501", # line too long (we enforce via line-length instead)
+    "RET504",
+    "RUF013",
+    "PTH123"
 ]
 
 [tool.ruff.lint.pydocstyle]