From dd3cc6f99a8dacdca13652422e1195bc9b1a25fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Sun, 23 Aug 2020 16:57:42 +0200 Subject: [PATCH] Remove stray enum instance MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This `enum LOG_LEVELS` declaration also included a _variable name_, causing https://github.com/RuntimeTools/appmetrics/issues/641. It ended up defining a `Log_levels` variable in every compilation unit that included "Log.h", which then caused duplicate symbols at link time. I don't know if there was a reason for this definition, but it looks like a bug to me … if not, maybe it can be fixed by just putting a `static` in front? idk. Thanks! --- org.eclipse.paho.mqtt.c/src/Log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.paho.mqtt.c/src/Log.h b/org.eclipse.paho.mqtt.c/src/Log.h index 48660c3..d4bb7e0 100644 --- a/org.eclipse.paho.mqtt.c/src/Log.h +++ b/org.eclipse.paho.mqtt.c/src/Log.h @@ -40,7 +40,7 @@ enum LOG_LEVELS { LOG_ERROR, LOG_SEVERE, LOG_FATAL, -} Log_levels; +}; /*BE