ed448-goldilocks: move Edwards and Montgomary to their own modules (#1300)

Author: daxpedda

ed448-goldilocks/src/curve.rs

@@ -1,9 +1,2 @@
-pub mod edwards;
-pub mod montgomery;
-mod scalar;
 pub(crate) mod scalar_mul;
 pub(crate) mod twedwards;
-
-pub use edwards::{AffinePoint, CompressedEdwardsY, EdwardsPoint};
-pub use montgomery::{MontgomeryPoint, ProjectiveMontgomeryPoint};
-pub use scalar::{EdwardsScalar, EdwardsScalarBytes, WideEdwardsScalarBytes};

ed448-goldilocks/src/curve/twedwards/extended.rs

@@ -1,9 +1,9 @@
 #![allow(non_snake_case)]
 #![allow(dead_code)]
 
-use crate::curve::edwards::EdwardsPoint as EdwardsExtendedPoint;
 use crate::curve::twedwards::affine::AffinePoint;
 use crate::curve::twedwards::extensible::ExtensiblePoint;
+use crate::edwards::EdwardsPoint as EdwardsExtendedPoint;
 use crate::field::FieldElement;
 use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 

ed448-goldilocks/src/curve/edwards.rs renamed to ed448-goldilocks/src/edwards.rs

@@ -11,5 +11,7 @@
 /// If this is a problem, one can use a different isogeny strategy (Decaf/Ristretto)
 pub(crate) mod affine;
 pub(crate) mod extended;
+mod scalar;
 pub use affine::AffinePoint;
 pub use extended::{CompressedEdwardsY, EdwardsPoint};
+pub use scalar::{EdwardsScalar, EdwardsScalarBytes, WideEdwardsScalarBytes};

ed448-goldilocks/src/curve/edwards/affine.rs renamed to ed448-goldilocks/src/edwards/affine.rs

@@ -1,4 +1,3 @@
-use crate::curve::edwards::EdwardsPoint;
 use crate::field::FieldElement;
 use crate::*;
 use core::ops::Mul;

ed448-goldilocks/src/curve/edwards/extended.rs renamed to ed448-goldilocks/src/edwards/extended.rs

@@ -4,8 +4,6 @@ use core::iter::Sum;
 use core::ops::{Add, AddAssign, Mul, MulAssign, Neg, Sub, SubAssign};
 
 use crate::constants::EDWARDS_BASEPOINT_ORDER;
-use crate::curve::edwards::affine::AffinePoint;
-use crate::curve::montgomery::MontgomeryPoint; // XXX: need to fix this path
 use crate::curve::scalar_mul::variable_base;
 use crate::curve::twedwards::extended::ExtendedPoint as TwistedExtendedPoint;
 use crate::field::FieldElement;

ed448-goldilocks/src/curve/scalar.rs renamed to ed448-goldilocks/src/edwards/scalar.rs

@@ -7,8 +7,8 @@ pub use scalar::{
     MODULUS_LIMBS, NZ_ORDER, ORDER, Scalar, ScalarBytes, WIDE_ORDER, WideScalarBytes,
 };
 
-use crate::curve::edwards::EdwardsPoint;
 use crate::curve::twedwards::extended::ExtendedPoint as TwExtendedPoint;
+use crate::edwards::EdwardsPoint;
 
 use elliptic_curve::bigint::{
     U448, const_monty_params,

ed448-goldilocks/src/field.rs

@@ -43,22 +43,25 @@ pub use subtle;
 pub(crate) mod constants;
 pub(crate) mod curve;
 pub(crate) mod decaf;
+pub(crate) mod edwards;
 pub(crate) mod field;
+pub(crate) mod montgomery;
 pub(crate) mod ristretto;
 #[cfg(feature = "signing")]
 pub(crate) mod sign;
 
 pub(crate) use field::{GOLDILOCKS_BASE_POINT, TWISTED_EDWARDS_BASE_POINT};
 
-pub use curve::{
-    AffinePoint, CompressedEdwardsY, EdwardsPoint, EdwardsScalar, EdwardsScalarBytes,
-    MontgomeryPoint, ProjectiveMontgomeryPoint, WideEdwardsScalarBytes,
-};
 pub use decaf::{
     AffinePoint as DecafAffinePoint, CompressedDecaf, DecafPoint, DecafScalar, DecafScalarBytes,
     WideDecafScalarBytes,
 };
+pub use edwards::{
+    AffinePoint, CompressedEdwardsY, EdwardsPoint, EdwardsScalar, EdwardsScalarBytes,
+    WideEdwardsScalarBytes,
+};
 pub use field::{MODULUS_LIMBS, ORDER, Scalar, WIDE_ORDER};
+pub use montgomery::{MontgomeryPoint, ProjectiveMontgomeryPoint};
 pub use ristretto::{CompressedRistretto, RistrettoPoint};
 #[cfg(feature = "signing")]
 pub use sign::*;

ed448-goldilocks/src/lib.rs

@@ -12,7 +12,7 @@
 
 // use crate::constants::A_PLUS_TWO_OVER_FOUR;
 use crate::EdwardsScalar;
-use crate::curve::edwards::extended::EdwardsPoint;
+use crate::edwards::extended::EdwardsPoint;
 use crate::field::FieldElement;
 use core::fmt;
 use core::ops::Mul;

ed448-goldilocks/src/curve/montgomery.rs renamed to ed448-goldilocks/src/montgomery.rs

@@ -14,7 +14,7 @@ use signature::Error;
 use subtle::{Choice, ConstantTimeEq};
 
 #[cfg(feature = "pkcs8")]
-use crate::{PUBLIC_KEY_LENGTH, curve::edwards::extended::PointBytes};
+use crate::{PUBLIC_KEY_LENGTH, edwards::extended::PointBytes};
 
 /// Ed448 secret key as defined in [RFC8032 § 5.2.5]
 ///