Skip to content

Commit 8fc6493

Browse files
young-yang03Young Yang
andauthored
Mbt upgrade SBOM file content (#1103)
* modified: .circleci/config.yml modified: Dockerfile_mbtci_template modified: Makefile modified: internal/artifacts/sbom.go modified: internal/commands/commands.go * modified: internal/artifacts/sbom.go modified: internal/commands/commands.go * modified: internal/artifacts/sbom.go * modified: Dockerfile_mbtci_template modified: internal/artifacts/sbom.go * modified: internal/artifacts/project.go modified: internal/artifacts/project_test.go modified: internal/artifacts/sbom.go * modified: internal/artifacts/sbom.go * modified: Makefile --------- Co-authored-by: Young Yang <young.yang03@sap.com>
1 parent 6d70b01 commit 8fc6493

File tree

7 files changed

+279
-48
lines changed

7 files changed

+279
-48
lines changed

.circleci/config.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,14 +136,14 @@ jobs:
136136
go install github.com/CycloneDX/cyclonedx-gomod/cmd/cyclonedx-gomod@latest
137137
cyclonedx-gomod version
138138
- run:
139-
name: install cyclonedx-bom
140-
command: |
141-
CYCLONEDX_BOM_PACKAGE=cyclonedx-bom
142-
CYCLONEDX_BOM_VERSION=0.0.9
143-
CYCLONEDX_BOM_BINARY=cyclonedx-bom
144-
npm install ${CYCLONEDX_BOM_PACKAGE}@${CYCLONEDX_BOM_VERSION} --no-save
145-
echo "${CYCLONEDX_BOM_BINARY} -h"
146-
npx ${CYCLONEDX_BOM_BINARY} -h
139+
name: install cyclonedx-npm
140+
command: |
141+
CYCLONEDX_NPM_PACKAGE=@cyclonedx/cyclonedx-npm
142+
CYCLONEDX_NPM_VERSION=1.11.0
143+
CYCLONEDX_NPM_BINARY=cyclonedx-npm
144+
npm install ${CYCLONEDX_NPM_PACKAGE}@${CYCLONEDX_NPM_VERSION} --no-save
145+
echo "${CYCLONEDX_NPM_BINARY} -h"
146+
npx ${CYCLONEDX_NPM_BINARY} -h
147147
- run:
148148
name: build mbt binary
149149
command: |

Dockerfile_mbtci_template

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ ARG CYCLONEDX_CLI_VERSION=0.24.2
1414
ARG CYCLONEDX_CLI_BINARY=cyclonedx
1515
ARG CYCLONEDX_GOMOD_VERSION=1.4.0
1616
ARG CYCLONEDX_GOMOD_BINARY=cyclonedx-gomod
17-
ARG CYCLONEDX_BOM_PACKAGE=cyclonedx-bom
18-
ARG CYCLONEDX_BOM_VERSION=0.0.9
19-
ARG CYCLONEDX_BOM_BINARY=cyclonedx-bom
17+
ARG CYCLONEDX_NPM_PACKAGE=@cyclonedx/cyclonedx-npm
18+
ARG CYCLONEDX_NPM_VERSION=1.11.0
19+
ARG CYCLONEDX_NPM_BINARY=cyclonedx-npm
2020

2121
# Environment variables
2222
ENV PYTHON /usr/bin/python3
@@ -293,12 +293,6 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
293293
&& echo "cyclonedx-gomod smoke tests!" \
294294
&& cyclonedx-gomod version
295295

296-
# Install cyclone-bom
297-
RUN set -ex \
298-
&& npm install --prefix /usr/local/ -g ${CYCLONEDX_BOM_PACKAGE}@${CYCLONEDX_BOM_VERSION} \
299-
&& echo "cyclonedx-bom smoke tests!" \
300-
&& npx ${CYCLONEDX_BOM_BINARY} -h
301-
302296
# Install curl and ca-certificates
303297
RUN set -ex \
304298
&& apt-get update \

Makefile

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,10 @@ CYCLONEDX_CLI_VERSION = 0.24.2
2323
CYCLONEDX_GOMOD_BINARY = cyclonedx-gomod
2424
CYCLONEDX_GOMOD_VERSION = latest
2525

26-
# cyclonedx-bom
27-
CYCLONEDX_BOM_PACKAGE = cyclonedx-bom
28-
CYCLONEDX_BOM_VERSION = 0.0.9
29-
CYCLONEDX_BOM_BINARY = cyclonedx-bom
30-
26+
# cyclonedx_npm
27+
CYCLONEDX_NPM_PACKAGE = @cyclonedx/cyclonedx-npm
28+
CYCLONEDX_NPM_VERSION = 1.11.0
29+
CYCLONEDX_NPM_BINARY = cyclonedx-npm
3130

3231
ifeq ($(OS),Windows_NT)
3332
CYCLONEDX_OS=win
@@ -70,10 +69,10 @@ lint:
7069

7170
# execute general tests
7271
tests:
73-
go test -v -count=1 -timeout 30m ./...
72+
go test -v -count=1 -timeout 60m ./...
7473
# check code coverage
7574
cover:
76-
go test -v -coverprofile cover.out ./... -count=1 -timeout 30m
75+
go test -v -coverprofile cover.out ./... -count=1 -timeout 60m
7776
go tool cover -html=cover.out -o cover.html
7877
open cover.html
7978

@@ -111,18 +110,20 @@ else
111110
cp $(CURDIR)/release/$(BINARY_NAME) $~/usr/local/bin/
112111
endif
113112

114-
# use for local development - > install cyclonedx-gomod, cyclonedx-cli and cyclonedx-bom
113+
# use for local development - > install cyclonedx-gomod, cyclonedx-cli and cyclonedx-npm
115114
install-cyclonedx:
116115
# install cyclonedx-gomod
117116
go install github.com/CycloneDX/cyclonedx-gomod/cmd/${CYCLONEDX_GOMOD_BINARY}@${CYCLONEDX_GOMOD_VERSION}
118117
echo "${CYCLONEDX_GOMOD_BINARY} version"
119118
${CYCLONEDX_GOMOD_BINARY} version
119+
120120
# install cyclonedx-cli
121121
curl -fsSLO --compressed "https://github.com/CycloneDX/cyclonedx-cli/releases/download/v${CYCLONEDX_CLI_VERSION}/${CYCLONEDX_CLI_BINARY}-${CYCLONEDX_OS}-${CYCLONEDX_ARCH}${CYCLONEDX_BINARY_SUFFIX}"
122122
mv ${CYCLONEDX_CLI_BINARY}-${CYCLONEDX_OS}-${CYCLONEDX_ARCH}${CYCLONEDX_BINARY_SUFFIX} $(GOPATH)/bin/${CYCLONEDX_CLI_BINARY}${CYCLONEDX_BINARY_SUFFIX}
123123
echo "${CYCLONEDX_CLI_BINARY} version:"
124124
${CYCLONEDX_CLI_BINARY} --version
125-
# install cyclonedx-bom
126-
npm install -g ${CYCLONEDX_BOM_PACKAGE}@${CYCLONEDX_BOM_VERSION}
127-
echo "${CYCLONEDX_BOM_BINARY} -h"
128-
npx ${CYCLONEDX_BOM_BINARY} -h
125+
126+
# install cyclonedx-npm
127+
npm install -g ${CYCLONEDX_NPM_PACKAGE}@${CYCLONEDX_NPM_VERSION}
128+
echo "${CYCLONEDX_NPM_BINARY} -h"
129+
npx ${CYCLONEDX_NPM_BINARY} -h

internal/artifacts/project.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
"github.com/pkg/errors"
1111

12-
dir "github.com/SAP/cloud-mta-build-tool/internal/archive"
12+
"github.com/SAP/cloud-mta-build-tool/internal/archive"
1313
"github.com/SAP/cloud-mta-build-tool/internal/commands"
1414
"github.com/SAP/cloud-mta-build-tool/internal/exec"
1515
"github.com/SAP/cloud-mta-build-tool/internal/logs"

internal/artifacts/project_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
. "github.com/onsi/ginkgo/extensions/table"
1212
. "github.com/onsi/gomega"
1313

14-
dir "github.com/SAP/cloud-mta-build-tool/internal/archive"
14+
"github.com/SAP/cloud-mta-build-tool/internal/archive"
1515
"github.com/SAP/cloud-mta-build-tool/internal/commands"
1616
"github.com/SAP/cloud-mta-build-tool/internal/exec"
1717
"github.com/SAP/cloud-mta/mta"

0 commit comments

Comments
 (0)