From 0c900dd508a88c93af4562467d83cd3918bdc3ed Mon Sep 17 00:00:00 2001 From: Gianluca Petrillo Date: Tue, 18 Nov 2025 11:46:26 -0800 Subject: [PATCH 1/3] Refactor SRTrkChi2PID class documentation and methods Following CAF coding guidelines. --- sbnanaobj/StandardRecord/SRTrkChi2PID.cxx | 48 +++++++---------------- 1 file changed, 15 insertions(+), 33 deletions(-) diff --git a/sbnanaobj/StandardRecord/SRTrkChi2PID.cxx b/sbnanaobj/StandardRecord/SRTrkChi2PID.cxx index 4393be05..5bb50c5f 100644 --- a/sbnanaobj/StandardRecord/SRTrkChi2PID.cxx +++ b/sbnanaobj/StandardRecord/SRTrkChi2PID.cxx @@ -1,38 +1,20 @@ -//////////////////////////////////////////////////////////////////////// -// \file SRTrkChi2PID.cxx -// \brief An SRTrkChi2PID is a high level track ParticlePID object for -// for larana Chi2ParticleID results. -//////////////////////////////////////////////////////////////////////// +/** + * @file SRTrkChi2PID.cxx + * @brief An SRTrkChi2PID is a high level track `anab::ParticlePID` object + * for larana `pid::Chi2ParticleID` results. + * @see SRTrkChi2PID.h + */ #include "sbnanaobj/StandardRecord/SRTrkChi2PID.h" -#include - -namespace caf +void caf::SRTrkChi2PID::setDefault() { + pdg = -5; + pid_ndof = -5; + chi2_muon = -5.0; + chi2_pion = -5.0; + chi2_kaon = -5.0; + chi2_proton = -5.0; + pida = -5; +} - SRTrkChi2PID::SRTrkChi2PID(): - pdg(-999), - pid_ndof(-99), - chi2_muon(std::numeric_limits::signaling_NaN()), - chi2_pion(std::numeric_limits::signaling_NaN()), - chi2_kaon(std::numeric_limits::signaling_NaN()), - chi2_proton(std::numeric_limits::signaling_NaN()), - pida(std::numeric_limits::signaling_NaN()) - { } - - SRTrkChi2PID::~SRTrkChi2PID(){ } - - void SRTrkChi2PID::setDefault() - { - pdg = -5; - pid_ndof = -5; - chi2_muon = -5.0; - chi2_pion = -5.0; - chi2_kaon = -5.0; - chi2_proton = -5.0; - pida = -5; - } - -} // end namespace caf -//////////////////////////////////////////////////////////////////////// From 299152f109fabe0b4c14b1b54f3d758a0d6f667c Mon Sep 17 00:00:00 2001 From: Gianluca Petrillo Date: Tue, 18 Nov 2025 11:49:57 -0800 Subject: [PATCH 2/3] Refactor SRTrkChi2PID class with default values Complying to SBN CAF coding guidelines. --- sbnanaobj/StandardRecord/SRTrkChi2PID.h | 35 +++++++++++++------------ 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/sbnanaobj/StandardRecord/SRTrkChi2PID.h b/sbnanaobj/StandardRecord/SRTrkChi2PID.h index bf17ba22..5512ef80 100644 --- a/sbnanaobj/StandardRecord/SRTrkChi2PID.h +++ b/sbnanaobj/StandardRecord/SRTrkChi2PID.h @@ -1,27 +1,29 @@ -//////////////////////////////////////////////////////////////////////// -// \file SRTrkChi2PID.h -//////////////////////////////////////////////////////////////////////// +/** + * @file SRTrkChi2PID.h + * @brief An SRTrkChi2PID is a high level track `anab::ParticlePID` object + * for larana `pid::Chi2ParticleID` results. + * @see SRTrkChi2PID.cxx + */ + #ifndef SRTRKCHI2PID_H #define SRTRKCHI2PID_H +#include "sbnanaobj/StandardRecord/SRConstants.h" + namespace caf { - /// Track PID from dE/dx v. residual range Chi2 - class SRTrkChi2PID + /// Track PID from dE/dx v. residual range χ². + struct SRTrkChi2PID { - public: - - SRTrkChi2PID(); - virtual ~SRTrkChi2PID(); - int pdg; ///< Min Chi2 pdg - int pid_ndof; ///< Number of degress of freedom in Chi2 PID fit - float chi2_muon; ///< dE/dx v. residual range Chi2 (muon hypothesis) - float chi2_pion; ///< dE/dx v. residual range Chi2 (pion hypothesis) - float chi2_kaon; ///< dE/dx v. residual range Chi2 (kaon hypothesis) - float chi2_proton; ///< dE/dx v. residual range Chi2 (proton hypothesis) + int pdg = -999; ///< PDG ID of the lowest Chi2. + int pid_ndof = -99; ///< Number of degress of freedom in Chi2 PID fit. + float chi2_muon = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (muon hypothesis). + float chi2_pion = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (pion hypothesis). + float chi2_kaon = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (kaon hypothesis). + float chi2_proton = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (proton hypothesis). - float pida; ///< PIDA + float pida = caf::kSignalingNaN; ///< Particle identification algorithm result (PIDA). void setDefault(); }; @@ -29,4 +31,3 @@ namespace caf } // end namespace #endif // SRTRKCHI2PID_H -////////////////////////////////////////////////////////////////////////////// From 40d0db1d2f0a10ff6ac7dfd952112ff5ef1c9011 Mon Sep 17 00:00:00 2001 From: Gianluca Petrillo Date: Tue, 18 Nov 2025 12:10:21 -0800 Subject: [PATCH 3/3] Typographical mispelling Found by Copilot. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- sbnanaobj/StandardRecord/SRTrkChi2PID.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbnanaobj/StandardRecord/SRTrkChi2PID.h b/sbnanaobj/StandardRecord/SRTrkChi2PID.h index 5512ef80..c9dc0d6c 100644 --- a/sbnanaobj/StandardRecord/SRTrkChi2PID.h +++ b/sbnanaobj/StandardRecord/SRTrkChi2PID.h @@ -17,7 +17,7 @@ namespace caf { int pdg = -999; ///< PDG ID of the lowest Chi2. - int pid_ndof = -99; ///< Number of degress of freedom in Chi2 PID fit. + int pid_ndof = -99; ///< Number of degrees of freedom in Chi2 PID fit. float chi2_muon = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (muon hypothesis). float chi2_pion = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (pion hypothesis). float chi2_kaon = caf::kSignalingNaN; ///< dE/dx v. residual range Chi2 (kaon hypothesis).