Add error check for more kinds of

selection

Author: SBeator

lib/sort-json-core.js

@@ -110,6 +110,10 @@ function selectedTextToSortedText(selectedText, indent, sortOrder) {
 
   let object = ast.program.body[0].declarations[0].init;
 
+  if (ast.program.body.length > 1 || object.type !== 'ObjectExpression') {
+    throw { message: 'Please make sure your selected text is a JS obejct!' };
+  }
+
   sortObject(object, sortOrder);
 
   let sortedText = generate.default(ast, {}, code).code;

test/extension.test.js

@@ -11,7 +11,6 @@ var assert = require('assert');
 // You can import and use all API from the 'vscode' module
 // as well as import your extension to test it
 var sorter = require('../lib/sort-json-core');
-var JSON5 = require('json5');
 
 suite('Extension Tests', function() {
   test('normal js object asc', function() {
@@ -63,6 +62,35 @@ suite('Extension Tests', function() {
     assert.equal(result, 'Please make sure your selected text is a JS obejct!');
   });
 
+  test('Not js object 3', function() {
+    var jsObject = `'111'`;
+
+    var result;
+    try {
+      result = sorter.sort(jsObject, 4, ['asc'], {});
+    } catch (e) {
+      result = e.message;
+    }
+
+    assert.equal(result, 'Please make sure your selected text is a JS obejct!');
+  });
+
+  test('Not js object 4', function() {
+    var jsObject = `{
+      a:1,
+      b:2
+    }; var b = 2;`;
+
+    var result;
+    try {
+      result = sorter.sort(jsObject, 4, ['asc'], {});
+    } catch (e) {
+      result = e.message;
+    }
+
+    assert.equal(result, 'Please make sure your selected text is a JS obejct!');
+  });
+
   test('normal js object desc', function() {
     var jsObject = `{
         user: 'user',