Skip to content

SAC2CRC Target argument parsing inefficent #1

@hv15

Description

@hv15

I made a change to the macro in d53c626 which introduced an extra parameter. Sadly, I had assumed that CMake does not check the number of arguments passed to the macro - in principle this is true, however CMake does check that all named arguments are given. As such, the LIBS argument is needed, even if it isn't relevent for the given SAC project, resulting in syntax like:

CREATE_SAC2CRC_TARGET ("modulename" "${DLL_BUILD_DIR}" "${DLL_BUILD_DIR}" "")

Suggested fix for this is to removed the name/required argument and instead check for extra passed arguments using ${ARGN} and parse these seperately - this actually potentially convienet solution to also allow for arbitary values that can be exposed with the project-specific sac2crc file...

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions