You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix autodiff numerical stability issues in BrussScaling benchmark
This commit addresses performance regression issues identified in PR #1275 by:
1. **Remove broken MooncakeVJP integration**:
- Remove Mooncake dependency from Project.toml
- Remove MooncakeVJP usage from BrussScaling.jmd
- Fix import statements and VJP method configurations
2. **Fix dependency version issues**:
- Keep DifferentiationInterface at v0.6 (compatible version)
- Remove references to non-functional MooncakeVJP method
3. **Add regression tests**:
- Add test_bruss_regression.jl to prevent future regressions
- Tests verify ForwardDiff numerical stability
- Tests check that problematic methods are properly removed
The root cause was incomplete MooncakeVJP integration causing numerical
instabilities in ForwardDiff operations, not actual performance regression.
ForwardDiff failures with NaN dt errors made it appear slower when it was
actually failing due to dependency incompatibilities.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
0 commit comments