Fix GaussAdjoint with ZygoteVJP for in-place ODE functions #1284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282
Summary
Previously,
GaussAdjointwithZygoteVJP()would fail when used with in-place ODE functions, throwing aMethodError: no method matching fiip(::Vector{Float64}, ::Vector{Float64}, ::Float64)because it was calling the in-place functionf(du, u, p, t)with only 3 arguments as if it were out-of-placef(u, p, t).Changes
SciMLBase.isinplace()Zygote.Bufferto allow mutation during forward pass while remaining differentiableTechnical Details
The key insight is using
Zygote.Bufferwhich enables Zygote to differentiate through in-place functions by:copy(du_buf)for the backward passTesting
test/gauss_zygote_inplace.jlwith comprehensive coverageTest Output
🤖 Generated with Claude Code