Possible bug in Surrogates.jl RTEA

[IJ05]

Describe the bug 🐞
Hello,
This is regarding a discrepancy that I have noticed while using the Surrogates.jl RTEA optimizer.
The mutated solutions according to lines: 1882 and 1883 are labelled as “x_new” and “y_new”. But when they are added back to the surrogate model, they are labelled as “new_x” and “new_y.” Is this a mistake, or have I got it completely wrong?

Expected behavior
I believe
add_point!(surrRTEA, new_x, new_y)
should be changed to:
add_point!(surrRTEA, x_new, y_new)

• Output of using Pkg; Pkg.status()

Status `C:\Users\user\.julia\environments\v1.11\Project.toml`
  [31c24e10] Distributions v0.25.115
  [86b6b26d] Evolutionary v0.11.1
⌃ [f6369f11] ForwardDiff v0.10.37
⌃ [e9467ef8] GLMakie v0.10.16
  [af5da776] GlobalSensitivity v2.7.0
  [f67ccb44] HDF5 v0.17.2
  [f213a82b] HomotopyContinuation v2.12.0
⌃ [7073ff75] IJulia v1.25.0
⌅ [ee78f7c6] Makie v0.21.16
⌃ [8913a72c] NonlinearSolve v4.1.0
⌃ [91a5bcdd] Plots v1.40.8
  [274fc56d] PythonPlot v1.0.5
  [8a4e6c94] QuasiMonteCarlo v0.3.3
⌃ [1ed8b502] SciMLSensitivity v7.70.0
  [6fc51010] Surrogates v6.10.0
  [37e2e46d] LinearAlgebra v1.11.0

• Output of versioninfo()

Commit 501a4f25c2 (2024-10-07 11:40 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 16 × AMD Ryzen 7 4700G with Radeon Graphics         
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver2)
Threads: 1 default, 0 interactive, 1 GC (on 16 virtual cores)```

[ChrisRackauckas]

@sathvikbhagavan I think what's more important here is, why would this not be caught by tests? Since you just took a look maybe you have the answer in your head.

[sathvikbhagavan]

The tests were commented. I have fixed it in #508

In #507, I had just updated the interface and didn't look into detail. I think optimization stuff can be written in a cleaner way. I will work on it once I get the docs part done.