-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Description
The EIP spec defines the 2 functions, each one returning 2 values:
https://github.com/SecurityTokenStandard/EIP-Spec/blob/master/eip/eip-1594.md#cantransfer--cantransferfrom
function canTransfer(address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);
function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);But the implementation returns 3 values:
EIP-Spec/contracts/ERC1594/IERC1594.sol
Lines 20 to 22 in cef4971
| // Transfer Validity | |
| function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32); | |
| function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32); |
EIP-Spec/contracts/ERC1594/ERC1594.sol
Line 124 in cef4971
| function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) { |
EIP-Spec/contracts/ERC1594/ERC1594.sol
Line 149 in cef4971
| function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) { |
If the implementation is correct, the EIP spec should be updated to reflect the truth.
ethereum/EIPs#1594
Metadata
Metadata
Assignees
Labels
No labels