Skip to content

EIP1594 - Different return values for canTransfer and canTransferFrom #23

@cleanunicorn

Description

@cleanunicorn

The EIP spec defines the 2 functions, each one returning 2 values:
https://github.com/SecurityTokenStandard/EIP-Spec/blob/master/eip/eip-1594.md#cantransfer--cantransferfrom

function canTransfer(address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);
function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (byte, bytes32);

But the implementation returns 3 values:

// Transfer Validity
function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32);
function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32);

function canTransfer(address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) {

function canTransferFrom(address _from, address _to, uint256 _value, bytes _data) external view returns (bool, byte, bytes32) {

If the implementation is correct, the EIP spec should be updated to reflect the truth.
ethereum/EIPs#1594

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions