[🐛 Bug]: Stop Method Fails to Terminate Node Server

[sathanRaj]

Description

I started the Browser Node using the org.openqa.selenium.grid.node.httpd.NodeServer class and need to stop the NodeServer in certain use cases.

I tried using the stop() method to stop the NodeServer, but the server does not stop, and the port remains occupied even after calling stop().

Expected behaviour: The stop() method should properly shut down the NodeServer and release the port.

Reproducible Code

//Code used to Start the server
NodeServer nodeServer = new NodeServer();
Server server = nodeServer.asServer(nodeConfiguration);
server.start();

//Code used to Stop the server
server.stop();

[selenium-ci]

@sathanRaj, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

[diemol]

This is not enough to triage your issue. Please add the node configuration and the logs. Also, the node cannot start on its own, I guess you are using a Hub as well.

[sathanRaj]

HubServerImpl.java

NodeServerImpl.java

CustomNode.java

JsonConfiguration.java

First, the HubServerImpl class will be started, followed by the NodeServerImpl class.
Then, I will make an API call to register a new node using the following API:

POST http://localhost:43400/session/121232/se/files

Payload:

{
"oprType": "stopBrowserNode",
"id": "node2"
}

The same API will be used to stop the previously started node.
Currently, the node starts without any issues, but it does not stop as expected.

[diemol]

Please post the code instead of attaching files. Or put them on a gist.

[sathanRaj]

https://github.com/sathanRaj/NodeServerIssue

[diemol]

Is seems you are overwriting a few parts of the standard behavior. Not sure how I can diagnose where the issue is. What have you tried so far?

[sathanRaj]

I need to dynamically start and stop the browser node using API requests.

[diemol]

Why can't you use dynamic grid or the different options docker selenium offers? I am sorry but we cannot troubleshoot your custom code.

[joerg1985]

@sathanRaj we had some fixes related to stopping the server backend. What version did you use?