Fix:ImageFields bug temporary fix (#1478)

* hot fix

* null check

* test cases update

* change for test

---------

Co-authored-by: tusmester <tusmester@gmail.com>

Author: hassanad94

packages/sn-controls-react/src/fieldcontrols/short-text.tsx

@@ -58,7 +58,8 @@ export const ShortText: React.FC<ReactClientFieldSetting<ShortTextFieldSetting>>
             {props.settings.DisplayName}
           </Typography>
           <Typography variant="body1" gutterBottom={true}>
-            {props.fieldValue || localization.noValue}
+            {/* Temporary hot fix */}
+            {typeof props.fieldValue !== 'string' ? '[OBJECT]' : props.fieldValue || localization.noValue}
           </Typography>
         </div>
       )

packages/sn-controls-react/test/__snapshots__/short-text.test.tsx.snap

@@ -1,5 +1,22 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`Short text field control in browse view should show [OBJECT] when iccorect type passed 1`] = `
+<div>
+  <WithStyles(ForwardRef(Typography))
+    gutterBottom={true}
+    variant="caption"
+  >
+    Display name
+  </WithStyles(ForwardRef(Typography))>
+  <WithStyles(ForwardRef(Typography))
+    gutterBottom={true}
+    variant="body1"
+  >
+    [OBJECT]
+  </WithStyles(ForwardRef(Typography))>
+</div>
+`;
+
 exports[`Short text field control in browse view should show the displayname and fieldValue when fieldValue is provided 1`] = `
 <div>
   <WithStyles(ForwardRef(Typography))

packages/sn-controls-react/test/short-text.test.tsx

@@ -24,6 +24,13 @@ describe('Short text field control', () => {
       const wrapper = shallow(<ShortText actionName="browse" settings={defaultSettings} />)
       expect(wrapper.find(Typography).last().text()).toBe(defaultLocalization.shortText.noValue)
     })
+    it('should show [OBJECT] when iccorect type passed', () => {
+      const value = { url: '' }
+      const wrapper = shallow(<ShortText fieldValue={value as any} actionName="browse" settings={defaultSettings} />)
+      expect(wrapper.find(Typography).first().text()).toBe(defaultSettings.DisplayName)
+      expect(wrapper.find(Typography).last().text()).toBe('[OBJECT]')
+      expect(wrapper).toMatchSnapshot()
+    })
   })
   describe('in edit/new view', () => {
     it('should set all the props', () => {