Change DialectProviders to use new ToDbConnection() and ToDbCommand() to get underlying ADO.NET interfaces

Author: mythz

src/ServiceStack.OrmLite.MySql/MySqlDialectProvider.cs

@@ -228,28 +228,12 @@ public string GetColumnDefinition(FieldDefinition fieldDefinition)
 
         protected MySqlConnection Unwrap(IDbConnection db)
         {
-            var dbAsync = db as MySqlConnection;
-            if (dbAsync != null)
-                return dbAsync;
-
-            var hasDb = db as IHasDbConnection;
-            if (hasDb != null)
-                return (MySqlConnection)hasDb.DbConnection;
-
-            throw new ArgumentException("{0} is not a MySqlConnection".Fmt(db.GetType().Name));
+            return (MySqlConnection)db.ToDbConnection();
         }
 
         protected MySqlCommand Unwrap(IDbCommand cmd)
         {
-            var cmdAsync = cmd as MySqlCommand;
-            if (cmdAsync != null)
-                return cmdAsync;
-
-            var hasDb = cmd as IHasDbCommand;
-            if (hasDb != null)
-                return (MySqlCommand)hasDb.DbCommand;
-
-            throw new ArgumentException("{0} is not an MySqlCommand".Fmt(cmd.GetType().Name));
+            return (MySqlCommand)cmd.ToDbCommand();
         }
 
         protected MySqlDataReader Unwrap(IDataReader reader)

src/ServiceStack.OrmLite.SqlServer/SqlServerOrmLiteDialectProvider.cs

@@ -463,28 +463,12 @@ public static string UseAliasesOrStripTablePrefixes(string selectExpression)
 
         protected SqlConnection Unwrap(IDbConnection db)
         {
-            var dbAsync = db as SqlConnection;
-            if (dbAsync != null)
-                return dbAsync;
-
-            var hasDb = db as IHasDbConnection;
-            if (hasDb != null)
-                return (SqlConnection)hasDb.DbConnection;
-
-            throw new ArgumentException("{0} is not an SqlConnection".Fmt(db.GetType().Name));
+            return (SqlConnection)db.ToDbConnection();
         }
 
         protected SqlCommand Unwrap(IDbCommand cmd)
         {
-            var cmdAsync = cmd as SqlCommand;
-            if (cmdAsync != null)
-                return cmdAsync;
-
-            var hasDb = cmd as IHasDbCommand;
-            if (hasDb != null)
-                return (SqlCommand)hasDb.DbCommand;
-
-            throw new ArgumentException("{0} is not an SqlCommand".Fmt(cmd.GetType().Name));
+            return (SqlCommand) cmd.ToDbCommand();
         }
 
         protected SqlDataReader Unwrap(IDataReader reader)

src/ServiceStack.OrmLite/OrmLiteConnectionFactory.cs

@@ -149,5 +149,21 @@ public static IDbConnection OpenDbConnection(this IDbConnectionFactory connectio
         {
             return ((OrmLiteConnectionFactory)connectionFactory).OpenDbConnection(namedConnection);
         }
+
+        public static IDbConnection ToDbConnection(this IDbConnection db)
+        {
+            var hasDb = db as IHasDbConnection;
+            return hasDb != null
+                ? hasDb.DbConnection
+                : db;
+        }
+
+        public static IDbCommand ToDbCommand(this IDbCommand dbCmd)
+        {
+            var hasDbCmd = dbCmd as IHasDbCommand;
+            return hasDbCmd != null
+                ? hasDbCmd.DbCommand
+                : dbCmd;
+        }
     }
 }

tests/ServiceStack.OrmLiteV45.Tests/App.config

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<configuration>
+  <appSettings>
+    <add key="servicestack:license" value="1001-e1JlZjoxMDAxLE5hbWU6VGVzdCBCdXNpbmVzcyxUeXBlOkJ1c2luZXNzLEhhc2g6UHVNTVRPclhvT2ZIbjQ5MG5LZE1mUTd5RUMzQnBucTFEbTE3TDczVEF4QUNMT1FhNXJMOWkzVjFGL2ZkVTE3Q2pDNENqTkQyUktRWmhvUVBhYTBiekJGUUZ3ZE5aZHFDYm9hL3lydGlwUHI5K1JsaTBYbzNsUC85cjVJNHE5QVhldDN6QkE4aTlvdldrdTgyTk1relY2eis2dFFqTThYN2lmc0JveHgycFdjPSxFeHBpcnk6MjAxMy0wMS0wMX0="/>
+    <add key="ClientSettingsProvider.ServiceUri" value=""/>
+  </appSettings>
+</configuration>