Merge pull request #66 from SimformSolutionsPvtLtd/fix/UNT-T28164_waveform_not_loaded_with_flatlist_after_scroll

fix(UNT-T28164): waveform not loaded with flatlist after scroll

Author: mukesh-simform

android/src/main/java/com/audiowaveform/AudioPlayer.kt

@@ -173,4 +173,8 @@ class AudioPlayer(
             audioPlaybackListener.cancel()
         }
     }
+
+    fun isHoldingAudioTrack(): Boolean {
+        return ::audioPlaybackListener.isInitialized
+    }
 }

android/src/main/java/com/audiowaveform/AudioWaveformModule.kt

@@ -34,6 +34,7 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
 
     companion object {
         const val NAME = "AudioWaveform"
+        const val MAX_NUMBER_OF_AUDIO_PLAYER = 30
     }
 
     override fun getName(): String {
@@ -100,6 +101,10 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
         obj: ReadableMap,
         promise: Promise
     ) {
+        if(audioPlayers.filter { it.value?.isHoldingAudioTrack() == true }.count() >= MAX_NUMBER_OF_AUDIO_PLAYER) {
+            promise.reject(Constants.LOG_TAG, "Too many players have been initialized. Please stop some players before continuing")
+        }
+
         val path = obj.getString(Constants.path)
         val key = obj.getString(Constants.playerKey)
         val frequency = obj.getInt(Constants.updateFrequency)
@@ -133,6 +138,7 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav
         val key = obj.getString(Constants.playerKey)
         if (key != null) {
             audioPlayers[key]?.stop(promise)
+            audioPlayers[key] = null // Release the player after stopping it
         } else {
             promise.reject("stopPlayer Error", "Player key can't be null")
         }

android/src/main/java/com/audiowaveform/WaveformExtractor.kt

@@ -16,6 +16,7 @@ import java.nio.ByteBuffer
 import java.util.concurrent.CountDownLatch
 import kotlin.math.pow
 import kotlin.math.sqrt
+import java.io.File
 
 class WaveformExtractor(
     context: ReactApplicationContext,
@@ -66,6 +67,11 @@ class WaveformExtractor(
 
     fun startDecode() {
         try {
+            if (!File(path).exists()) {
+                promise.reject("File Error", "File does not exist at the given path.")
+                return
+            }
+
             val format = getFormat(path) ?: error("No audio format found")
             val mime = format.getString(MediaFormat.KEY_MIME) ?: error("No MIME type found")
             decoder = MediaCodec.createDecoderByType(mime).also {

ios/AudioWaveform.swift

@@ -172,6 +172,7 @@ class AudioWaveform: RCTEventEmitter {
     let key = args?[Constants.playerKey] as? String
     if(key != nil){
       audioPlayers[key!]?.stopPlayer(result: resolve)
+      audioPlayers[key!] = nil // Release the player after stopping it
     } else {
       reject(Constants.audioWaveforms, "Can not stop player, Player key is null", NSError())
     }

src/components/Waveform/Waveform.tsx

@@ -10,6 +10,7 @@ import {
   PanResponder,
   ScrollView,
   View,
+  type LayoutChangeEvent,
   type LayoutRectangle,
   type NativeTouchEvent,
 } from 'react-native';
@@ -114,7 +115,9 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
         durationType: DurationType.max,
       });
       if (!isNil(duration)) {
-        setSongDuration(duration);
+        const audioDuration = Number(duration);
+        setSongDuration(audioDuration > 0 ? audioDuration : 0);
+        return Promise.resolve(audioDuration);
       } else {
         return Promise.reject(
           new Error(`Could not get duration for path: ${path}`)
@@ -129,7 +132,10 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
     try {
       const prepare = await preparePlayerForPath();
       if (prepare) {
-        await getAudioDuration();
+        const duration = await getAudioDuration();
+        if (duration < 0) {
+          await getAudioDuration();
+        }
       }
     } catch (err) {
       console.error(err);
@@ -174,7 +180,6 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
         const result = await stopPlayer({
           playerKey: `PlayerFor${path}`,
         });
-        await preparePlayerForPath();
         if (!isNil(result) && result) {
           setCurrentProgress(0);
           setPlayerState(PlayerState.stopped);
@@ -197,6 +202,10 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
   const startPlayerAction = async (args?: IStartPlayerRef) => {
     if (mode === 'static') {
       try {
+        if (playerState === PlayerState.stopped) {
+          await preparePlayerForPath();
+        }
+
         const play = await playPlayer({
           finishMode: FinishMode.stop,
           playerKey: `PlayerFor${path}`,
@@ -409,7 +418,13 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
 
     const tracePlaybackValue = onCurrentDuration(data => {
       if (data.playerKey === `PlayerFor${path}`) {
-        setCurrentProgress(data.currentDuration);
+        const currentAudioDuration = Number(data.currentDuration);
+
+        if (!isNaN(currentAudioDuration)) {
+          setCurrentProgress(currentAudioDuration);
+        } else {
+          setCurrentProgress(0);
+        }
       }
     });
 
@@ -500,18 +515,17 @@ export const Waveform = forwardRef<IWaveformRef, IWaveform>((props, ref) => {
       <View
         ref={viewRef}
         style={styles.waveformInnerContainer}
-        onLayout={() => {
-          viewRef.current?.measure((_x, _y, width, height, pageX, pageY) => {
-            setViewLayout({ height, width, x: pageX, y: pageY });
-          });
+        onLayout={(event: LayoutChangeEvent) => {
+          const { height, width, x, y } = event.nativeEvent.layout;
+          setViewLayout({ height, width, x, y });
         }}
         {...(mode === 'static' ? panResponder.panHandlers : {})}>
         <ScrollView
           horizontal
           ref={scrollRef}
           style={styles.scrollContainer}
           scrollEnabled={mode === 'live'}>
-          {waveform.map((amplitude, indexCandle) => (
+          {waveform?.map?.((amplitude, indexCandle) => (
             <WaveformCandle
               key={indexCandle}
               index={indexCandle}